1138778 - [ringtones] Don't resolve promises until indexedDB transactions are completed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[Jim Porter (:squib)]

This comes from bug 1116732 comment 15. Sometimes we close the ringtones app before a read-write transaction completes, causing it to roll back the transaction. I haven't seen this in action myself, but let's be safe and fix it.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] jimporter:ringtones-transact > mozilla-b2g:master

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8571729 [details] [review]
[gaia] jimporter:ringtones-transact > mozilla-b2g:master

Looks good to me. I'm assuming you've tested the modification with the ringtones app to ensure that adding and deleting still work as expected.

I'm glad you caught this. There was a serious bug in asyncStorage.js based on calling callbacks when requests completed instead of when the transaction was completed.

I'd recommend that you uplift this to 2.2

Comment 3

[David Flanagan [:djf]]

Comment on attachment 8571729 [details] [review]
[gaia] jimporter:ringtones-transact > mozilla-b2g:master

Oops, forgot to set r+ with my previous comment.

Comment 4

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/928c224aa2728015964cfa5732c26edb460c948d

Comment 5

[Carsten Book [:Tomcat]]

reverted for causing https://treeherder.mozilla.org/logviewer.html#?job_id=1480732&repo=b2g-inbound

Comment 6

[Jim Porter (:squib)]

Today I learned that Autolander doesn't care if you broke all the tests! Fixing...

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] jimporter:ringtones-transact-fix > mozilla-b2g:master

Comment 8

[Jim Porter (:squib)]

Attachment: Interdiff

Comment 9

[Jim Porter (:squib)]

Comment on attachment 8575156 [details] [review]
[gaia] jimporter:ringtones-transact-fix > mozilla-b2g:master

Re-review time! I ran the tests myself this time instead of blindly trusting Autolander, and everything looks good.

Comment 10

[David Flanagan [:djf]]

Comment on attachment 8575156 [details] [review]
[gaia] jimporter:ringtones-transact-fix > mozilla-b2g:master

looks good to me.

Comment 11

[Jim Porter (:squib)]

Forgot to mark checkin-needed...

Comment 12

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c64956619cd1af525a96a0ee4cd1b44baa0d5b53