1138780 - Lots of "TypeError: can't access dead object" logspam in every mochitest-dt run

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

See this log for example:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64-debug/1425329849/mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm120-tests1-linux64-build1.txt.gz

Now recoil in horror at the sheer volume of spam along the lines of the below:
14:19:41     INFO -  console.error:
14:19:41     INFO -    Message: TypeError: can't access dead object
14:19:41     INFO -    Stack:
14:19:41     INFO -      CanvasFrameAnonymousContentHelper.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/highlighter.js:469:7
14:19:41     INFO -  BoxModelHighlighter.prototype<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/highlighter.js:1005:5
14:19:41     INFO -  unhighlightAll@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/commands/highlight.js:30:5
14:19:41     INFO -  exports.items<.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/commands/highlight.js:97:9
14:19:41     INFO -  Requisition.prototype.exec/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/cli.js:2098:16
14:19:41     INFO -  createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:239:18
14:19:41     INFO -  Task_spawn@resource://gre/modules/Task.jsm:164:12
14:19:41     INFO -  exports.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/host.js:72:10
14:19:41     INFO -  Requisition.prototype.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/cli.js:2097:14
14:19:41     INFO -  helpers._exec@chrome://mochitests/content/browser/browser/devtools/commandline/test/helpers.js:936:12
14:19:41     INFO -  @chrome://mochitests/content/browser/browser/devtools/commandline/test/helpers.js:1225:24
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9
14:19:41     INFO -  @chrome://mochitests/content/browser/browser/devtools/commandline/test/helpers.js:1224:1
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43
14:19:41     INFO -  then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9
14:19:41     INFO -  Promise.prototype.then/</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/promise.js:67:17
14:19:41     INFO -  setTimeout_timer@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/promise.js:98:5


Is there something we can do about all this? I shudder to think about how much bloat it's putting in the logs.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Then there's this one in the same log:
14:25:43     INFO -  [8240] WARNING: Silently denied access to property |undefined|: Access to privileged JS object not permitted (@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/script.js:1167): file /builds/slave/m-cen-l64-d-000000000000000000/build/src/js/xpconnect/wrappers/XrayWrapper.cpp, line 192

Comment 2

[Patrick Brosset <:pbro>]

I don't know about the one in comment 1, but for comment 0, we can silence the error altogether here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/highlighter.js#465
It used to be silent (i.e. no console.error in the catch block), because if that fails, it's fine, really. And at some stage, the console.error was added.
I think we just need to remove it.

Comment 3

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: bz://1138780/pbrosset

/r/4531 - Bug 1138780 - Silence the CanvasFrameAnonymousContentHelper destroy error; r=miker

Pull down this commit:

hg pull review -r 3c187448b0a7b5e0c940865f35fc4078b34f353c

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8571826 [details]
MozReview Request: bz://1138780/pbrosset

https://reviewboard.mozilla.org/r/4529/#review3795

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/145432552ec0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/145432552ec0

Comment 8

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1138780 - Silence the CanvasFrameAnonymousContentHelper destroy error; r=miker