Closed
Bug 1138784
Opened 9 years ago
Closed 9 years ago
Various "SyntaxError: missing ; before statement" errors during browser_dbg_parser-02.js and browser_dbg_parser-04.js
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox39 fixed)
RESOLVED
FIXED
Firefox 39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: RyanVM, Assigned: past)
Details
Attachments
(1 file, 1 obsolete file)
3.92 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
In the log below: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64-debug/1425329849/mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm120-tests1-linux64-build1.txt.gz I see various tests that hit errors like: 14:34:09 INFO - 426 INFO TEST-START | browser/devtools/debugger/test/browser_dbg_parser-02.js 14:34:09 INFO - threw an exception: SyntaxError: missing ; before statement 14:34:09 INFO - Stack: Parser.prototype.get@resource:///modules/devtools/Parser.jsm:64:21 14:34:09 INFO - test@chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_parser-02.js:13:16 14:34:09 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:717:9 14:34:09 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:611:7 14:34:09 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59 14:34:09 INFO - Line: 64, column: 20 14:34:09 INFO - --DOCSHELL 0x7eff399d1f00 == 9 [pid = 8240] [id = 436] 14:34:09 INFO - 427 INFO TEST-OK | browser/devtools/debugger/test/browser_dbg_parser-02.js | took 873ms Is it possible to silence these?
Assignee | ||
Comment 1•9 years ago
|
||
I don't think we need to dump to the console for errors that are handled, but Victor knows this code best, so up to him.
Attachment #8572606 -
Flags: review?(vporof)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8572606 [details] [diff] [review] Don't dump errors that are already handled by the parser Review of attachment 8572606 [details] [diff] [review]: ----------------------------------------------------------------- Thing is... by removing that we'll going to ignore more serious syntax errors. Maybe we can have a silent mode that's active during tests?
Attachment #8572606 -
Flags: review?(vporof)
Comment 3•9 years ago
|
||
s/we'll/we're/
Assignee | ||
Updated•9 years ago
|
Attachment #8572606 -
Attachment is obsolete: true
Comment 5•9 years ago
|
||
Comment on attachment 8576516 [details] [diff] [review] Don't dump errors in tests that are already handled by the parser v2 Review of attachment 8576516 [details] [diff] [review]: ----------------------------------------------------------------- Nice
Attachment #8576516 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/749740c78886
Reporter | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/749740c78886
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•