Closed Bug 1138789 Opened 10 years ago Closed 10 years ago

Loop Server Test Mode: NODE_ENV=test npm start fails to start the Loop Server

Categories

(Hello (Loop) :: Server, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vladikoff, Unassigned)

Details

Hey, we used to use `NODE_ENV=test npm start` to test Loop's FxA Integration, but since version 0.15 I can no longer use that command to start the server. See output: ``` ➜ loop-server git:(master) ✗ NODE_ENV=test npm start mozilla-loop-server@0.15.6 start /Users/vladikoff/mozilla/fxa-local-dev/loop-server make runserver {"Timestamp":1425356916406000000,"Logger":"mozilla-loop-server","Type":"Error: unknown type of connection in createClient()","Severity":0,"Pid":93496,"EnvVersion":"2.0"} ``` Any ideas?
Flags: needinfo?(rhubscher)
Flags: needinfo?(alexis+bugs)
Hello you can use the loadtest configuration or create your dev configuration from the sample.json file. The test file is used for tests only. NODE_ENV=loadtest node loop/index.js
Flags: needinfo?(rhubscher)
I believe we've seen that in the past, yes. See https://github.com/mozilla-services/loop-server/commit/ff46052074b4b64aa87cb8b2460161b2fb4672d6 Adding the default port and host in the settings can probably resolve this. https://github.com/mozilla-services/loop-server/blob/master/config/test.json#L4-L12.
Flags: needinfo?(alexis+bugs)
Thank you for the information! I will update our FxA Test configs based on this.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This should fix it actually, without you needing to change anything: https://github.com/mozilla-services/loop-server/commit/ad77d042431268a305a67739a4600fad4ac554cf
You need to log in before you can comment on or make changes to this bug.