Closed
Bug 1138807
Opened 9 years ago
Closed 9 years ago
Treat user cancelling of HTTPHandlerPane as Success
Categories
(Firefox :: Shell Integration, defect)
Tracking
()
RESOLVED
FIXED
Firefox 39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: hectorz, Assigned: hectorz)
Details
Attachments
(1 file, 1 obsolete file)
|
1.29 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
In nsWindowsShellService::SetDefaultBrowser, the comment below |rv = LaunchHTTPHandlerPane();| says "The above call should never really fail, but just in case fallback to showing control panel for all defaults". However, the returned value of LaunchHTTPHandlerPane will be NS_ERROR_FAILURE if user cancels the http handler pane, either by pressing ESC or clicking outside the pane. This will bring up a control panel, which is kinda weird.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8571794 -
Flags: review?(jmathies)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8571794 -
Attachment is obsolete: true
Attachment #8571794 -
Flags: review?(jmathies)
Attachment #8571795 -
Flags: review?(jmathies)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8571795 [details] [diff] [review] Patch, trailing spaces removed Looks great, thanks!
Attachment #8571795 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d264396bfcf1
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/cd1f281e562c
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd1f281e562c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
You need to log in
before you can comment on or make changes to this bug.
Description
•