1138858 - [Nexus 5][Settings]The PIN code screen can't pop up after you turn off the airplane mode.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Lance（leave from Mozilla）]

[1.Description]:
[Nexus 5][Settings]After you turn off the airplane mode, the PIN code page can't pop up.
Found time:16:52
See attachment:1652.mp4 and logcat_1652.txt

[2.Testing Steps]: 
1.Insert CU/CMCC card into device.
2.Turn on device.
3.Launch Settings, turn on the SIM PIN code.
4.Turn on airplane mode, then turn off it.

Note: The bug does not exist in Flame 2.2.

[3.Expected Result]: 
4.The PIN code screen should pop up immediately.

[4.Actual Result]: 
4.The PIN code screen can't display.

[5.Reproduction build]: 
Build ID               20150302162504
Gaia Revision          062d395273e70b8688a91b5a2b34c0cc7afc679f
Gaia Date              2015-03-02 22:12:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5a7cb3b9f78e
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150302.194900
Firmware Date          Mon Mar  2 19:49:17 EST 2015
Bootloader             HHZ12d

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
The bug does not exist in Flame 2.2.

Comment 1

[Lance（leave from Mozilla）]

Attachment: logcat_1652.txt

Comment 2

[Lance（leave from Mozilla）]

Attachment: 1652.MP4

Comment 3

[Eric Chang [:ericcc] [:echang]]

Nominate this for breaking existing functionality.
But we need to know this is L related or Nexus-5 specific.

Comment 4

[howie [:howie]]

Should be Gecko passing no event to Gaia. qawanted to check if this happens in Nexus 5 Lollipop v3.0?

Comment 5

[Shine(Leave from Mozilla)]

Attachment: logcat_N5v3.0

This problem can be repro on latest build of N5 v3.0.
See attachment: logcat_N5v3.0_0833.txt
Occurrence time: 08:33
Fail rate: 3/3

N5 v3.0 build:
Build ID               20150308160204
Gaia Revision          fea83511df9ccba64259346bc02ebf2c417a12c2
Gaia Date              2015-03-08 06:36:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eab4a81e4457
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150308.192431
Firmware Date          Sun Mar  8 19:24:47 EDT 2015
Bootloader             HHZ12d

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi all,
According to different h/w modem behaviour, it's not necessarily true that turning on/off airplane mode triggers SIM card state change. That is, it could happen that the pin code screen doesn't pop up after turning off airplane mode. I believe Nexus 5 is one case.

After turning off airplane mode in nexus 5, even without entering sim pin code, I could use telephony features (voice call, sms,...) without problems. So this looks to me a Nexus-5 behaviour issue but not a regression.

I add 'qawanted' again to ask for verifying if any telephony feature is broken due to not entering pin code in this case. If NO, then I believe we could close this bug as invalid. Thanks.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

More information: Per https://bugzilla.mozilla.org/show_bug.cgi?id=1071210#c25  there's a config controlling the behaviour. And Nexus 5 has |persist.radio.apm_sim_not_pwdn| set to 1 that meets the current behaviour.

Comment 8

[bhavana bajaj [:bajaj]]

Looks like a DUP of https://bugzilla.mozilla.org/show_bug.cgi?id=1133465 ? We are waiting for more info on that bug.

Comment 9

[Eric Chang [:ericcc] [:echang]]

Just had an offline talk with Hsin-yi,
1. There might be other cases that need to investigate if we hit that, e.g. SIM manager test cases.. but we can save the time.
2. We are not shipping images for Nexus 5 officially.
3. Changing the persist.radio.apm_sim_not_pwdn settings, so the behavior is the same as Flame is a quick and easy solution for now, although current Nexus behavior seems to be much logical.
4. Note: This is a build time setting.

Suggest to fix, NI Wesley for comment.

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #7)
> More information: Per
> https://bugzilla.mozilla.org/show_bug.cgi?id=1071210#c25  there's a config
> controlling the behaviour. And Nexus 5 has |persist.radio.apm_sim_not_pwdn|
> set to 1 that meets the current behaviour.

Comment 10

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage:
Root cause is that current config for Nexus5 is different from Flame's.
We would like to align the behaviors to smooth QA testing. So this is sort of testing blocker.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Viral,
As you are the person who fixed bug 1071210, do you mind taking this bug that the solution is the same as that for 1071210? Thank you.

Comment 12

[viral [:viralwang]]

Attachment: set persist.radio.apm_sim_not_pwdn=0

Hi Hsinyi,

I think it should be good after we set persist.radio.apm_sim_not_pwdn=0

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8576509 [details] [review]
set persist.radio.apm_sim_not_pwdn=0

Yup, we verified that setting the property to 0 made SIM Pin dialogue work as expected. Thank you, Viral :D

Comment 14

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/device-hammerhead/commit/9be31ff74652fe3f835b8a5f5ae3e29e3156cbae

Comment 15

[Lance（leave from Mozilla）]

After you turn off airplane mode, you must launch Phone/Message/Contacts app or lock screen then unlock, the SIM PIN dialogue will pop up. If you launch other app, the dialogue still can't pop up. So, this question the same with bug 1133465, please see bug 1133465, thanks.

Comment 16

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Lance from comment #15)
> After you turn off airplane mode, you must launch Phone/Message/Contacts app
> or lock screen then unlock, the SIM PIN dialogue will pop up. If you launch
> other app, the dialogue still can't pop up. So, this question the same with
> bug 1133465, please see bug 1133465, thanks.

Please note that this is not the same issue as bug 1133465.

This bug was talking about even we launched phone apps, NO SIM PIN dialogue popped out eventually. However, that didn't affect any telephony features. That is, even without entering SIM PIN, we still could dial out voice calls, etc.

Comment 17

[Pi Wei Cheng [:piwei] (inactive)]

Removing qawanted due to the question has been answered on comment 7 and comment 10.

Comment 18

[KTucker [:KTucker][Inactive 3/4/2016]]

Lance, can you verify this please?

Comment 19

[Lance（leave from Mozilla）]

Hi KTucker,

Now, after you turn off airplane mode, the device can't recognise the SIM card, you must launch Phone/Message/Contacts app or lock screen then unlock, the SIM PIN dialogue will pop up. If you launch other app, the dialogue still can't pop up.

Steps:
1.Insert CMCC card into device.
2.Turn on device.
3.Launch Settings, turn on the SIM PIN code.
4.Turn on airplane mode, then turn off it.

Expected Result: 
4.The PIN code screen should pop up immediately.

Actual Result: 
4.The PIN code screen can't display, unless you launch Phone/Message/Contacts app or lock screen then unlock.

Fail rate:3/3
See attachment:1435.mp4

Nexus 5_2.2 version:
Build ID               20150315162500
Gaia Revision          a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gaia Date              2015-03-15 14:33:22
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/18619f8f6c5c
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150315.195744
Firmware Date          Sun Mar 15 19:57:59 EDT 2015
Bootloader             HHZ12d

Comment 20

[Lance（leave from Mozilla）]

Attachment: 1435.MP4

Comment 21

[KTucker [:KTucker][Inactive 3/4/2016]]

Please see Comment 19. Is this the expected behavior now Eric?

Comment 22

[Eric Chang [:ericcc] [:echang]]

AFAIK, this is expeced, but ni UX Jenny for confirmation.

Comment 23

[Jenny Lee]

Hello Eric,

Behavior described in comment 19 is expected. It makes more sense to ask user for PIN only when he's trying to use SIM card required app, asking for PIN right after airplane mode is turned off seems out of context. Thanks!

Comment 24

[Hermes Cheng (inactive after July 27, 2015)]

According to comment 19 & 23, I believe we can close this bug.

Comment 25

[Eric Chang [:ericcc] [:echang]]

I think this is as described in #c23
Turn airplane mode ON -> open app (except comms apps) -> no sim pin request -> open comms apps -> sim pin request pops up

But in #c19, we explicitly turn airplane mode off in step 4, we should expect sim pin request every time we do that.

Comment 26

[Coler]

This issue has been verified successfully on Nexus 5_2.2&3.0. The STR is same as Comment 0.It will pop PIN code page autimatically after turnning airplane mode off.
Reproduce rate:0/5
Attachmen:Verify.MP4
Device Nexus 5_2.2 build(Pass)
Build ID               20150419002502
Gaia Revision          c15a2b6d3a783813959c2b3bffd2a131f4270b9e
Gaia Date              2015-04-17 17:49:32
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cc02ee38b252
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150419.041307
Firmware Date          Sun Apr 19 04:13:23 EDT 2015
Bootloader             HHZ12f

Device Nexus 5_3.0 build(Pass)
Build ID               20150419160202
Gaia Revision          c6b04efa0f31a584e6ee0a46dd2b64c1e3c29adc
Gaia Date              2015-04-17 21:10:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a32e3b93c8d8
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150419.193737
Firmware Date          Sun Apr 19 19:37:53 EDT 2015
Bootloader             HHZ12f

Comment 27

[Coler]

Attachment: Verify.MP4