1139003 - Remove new Mozilla wordmark from tab on Firefox family navigation

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Mike Alexis [:malexis]]

Looks like the new Mozilla wordmark isn't ready for prime time. Need to remove and replace with the older version. 

Alex can you make this change today?

Comment 1

[Alex Gibson [:agibson]]

By wordmark, do we mean the tabzilla tab in the Firefox Family navigation?

https://github.com/mozilla/bedrock/blob/master/media/img/firefox/family/nav-sprite-high-res.png

Do we have a replacement graphic we can revert to?

Comment 2

[Jennifer Bertsch [:jbertsch]]

Let's hold on this one for half a day while Matej and I regroup with MEM.

But in the meantime, it would be great if Ty could provide a new file.

Comment 3

[Jennifer Bertsch [:jbertsch]]

Nevermind on holding.  Ty will provide an image.  Let's get this out today.

Comment 4

[Alex Gibson [:agibson]]

Just to be clear, this request will remove the wordmark on all pages where the new family nav is used.

Comment 5

[Jennifer Bertsch [:jbertsch]]

(In reply to Alex Gibson [:agibson] from comment #4)
> Just to be clear, this request will remove the wordmark on all pages where
> the new family nav is used.

Correct. 

It needs to be updated on 4 pages:
/mwc
/firefox/os
/firefox/os/devices
/firefox/partners

Comment 6

[Ty Flanagan]

Attachment: nav-sprite_updated.png

Here is an updated sprite PNG we can use to replace the newest tabzilla sprite image.

Comment 7

[Alex Gibson [:agibson]]

Ty, could you please update the high-res version? https://github.com/mozilla/bedrock/blob/master/media/img/firefox/family/nav-sprite-high-res.png

Many thanks

Comment 8

[Ty Flanagan]

Attachment: nav-sprite-hi-res_updated.png

And here is the hi-res version

Comment 9

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c368d3472c324ce324fa6d51267db34e411587cd
[fix bug 1139003] Remove new Mozilla wordmark from tab on Firefox family navigation

https://github.com/mozilla/bedrock/commit/8bcb3c5b7cf03ed614a5d50fdf5badd28a4eae5c
Merge pull request #2811 from alexgibson/bug-1139003-remove-tabzilla-wordmark-family-nav

[fix bug 1139003] Remove new Mozilla wordmark from tab on Firefox family nav

Comment 11

[Mike Alexis [:malexis]]

The mystery continues as to why the wordmark did not update. Still seeing the wrong one. Obviously not a cache issue as it's been 24 hours. Any ideas?

If we can't resolve the issue soon, we need to remove the tab entirely until resolved.

Comment 12

[Alex Gibson [:agibson]]

Peculiar, this shows the correct updated image:

https://mozorg.cdn.mozilla.net/media/img/firefox/family/nav-sprite-high-res.png

However this one is still showing the old asset:

https://mozorg.cdn.mozilla.net/media/img/firefox/family/nav-sprite-high-res.a4d086593854.png

Comment 13

[Paul [:pmac] McLanahan]

I believe I know what's up. The image was updated and when it deployed it had a new name "nav-sprite-high-res.547f151cf8b8.png". The one agibson linked above has a slightly different name "nav-sprite-high-res.a4d086593854.png" which is what we want for cache busting.

The problem is that the reference to this file is in CSS, and that file did not change. The deployment system compiles all of the LESS into CSS, then concatenates and compresses the CSS into bundles, then copies that bundle into a file with the md5 hash of the file contents in the name (like the above). The problem I think is that this file content check is done before the sweep by the deployment system that updates references to images and fonts and whatnot in the CSS to the unique file names with the md5 hashes in them. So, the CSS file with the same name as the old CSS file will be deployed, but because the CDN already has a file by that name it won't be loaded because it's been cached, and the cached version still refers to the old image file.

The temporary fix is to make any tiny change to the LESS file that refers to these images and push that. That will change the file name of the CSS and thus bust the cache. Fixing this so that it doesn't happen again will be slightly more trouble, but I'll file a bug now for it and start seeing what I can do.

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/632122edf4ff49638267a829c83ffb46289c5064
[fix bug 1139003] Cache bust tabzilla tab image sprite

https://github.com/mozilla/bedrock/commit/515b955df8d2fb4dbe4d088511d8f67cb6f7914c
Merge pull request #2814 from alexgibson/bug-1139003-bust-tabzilla-image

[fix bug 1139003] Cache bust tabzilla tab image sprite