1139005 - Need to check the return value of AutoJSAPI.init in canvas EncodeCallback

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: jsapi

This was causing problems if the callback is called after the window has already been torn down.

Comment 1

[Alfredo Yang (:alfredo)]

Comment on attachment 8572033 [details] [diff] [review]
jsapi

Review of attachment 8572033 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
BTW, how do you reproduce this bug? I doubt this bug probably be something like https://crash-stats.mozilla.com/report/index/981be8cb-79ef-4f04-b44d-bc9b22150115.

Comment 2

[StevenLee[:slee]]

As bug 1121899 comment 23, uplift to 2.2+.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e83a9eba19f

I had a patch that made this happen more often. It was just a coincidence.

Comment 4

[Alfredo Yang (:alfredo)]

Comment on attachment 8572033 [details] [diff] [review]
jsapi

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1139005
User impact if declined: gallery crash in low memory device (256mb)
Testing completed: local test is fine.
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: na

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e83a9eba19f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5a8abcedad3b