Closed Bug 1139012 Opened 5 years ago Closed 5 years ago

Telemetry for Windows 8 geolocation provider for MLS fallback rate

Categories

(Core :: DOM: Geolocation, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: garvan, Assigned: garvan)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1129633 +++

Add probe for rate of fallback to MLS. If this rate is high, then further investigation is warranted as to what the circumstance is. 

We can use this to compare to the same metrics in the CoreLocation provider:
http://telemetry.mozilla.org/#filter=nightly%2F38%2FGEOLOCATION_OSX_SOURCE_IS_MLS%2Fsaved_session%2FFirefox%2FDarwin
Attachment #8574678 - Flags: review?(cpeterson)
Comment on attachment 8574678 [details] [diff] [review]
add GEOLOCATION_WIN8_SOURCE_IS_MLS probe

Review of attachment 8574678 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: dom/system/windows/WindowsLocationProvider.cpp
@@ +32,5 @@
>    if (!coords) {
>      return NS_ERROR_FAILURE;
>    }
>  
> +  Telemetry::Accumulate(Telemetry::GEOLOCATION_WIN8_SOURCE_IS_MLS, true);

Maybe move the Telemetry::Accumulate() call before this function's error returns. For our telemetry, we care that we called MLS, which is independent of whether there was a client-side error.
Attachment #8574678 - Flags: review?(cpeterson) → review+
Thanks Chris.

Your question is a good one, but I haven't added the telemetry for that case just yet. This probe is for successful responses from Win8 or MLS. I want to add another one for the question you have which is for the error cases, where it fell back to A or B and errored out. 
The probe of the error states is a little tricker, I because the states can cascade (error state in A _and_ B). 
I hope to draw a full picture of how this provider behaves because it has the most code paths, and for some of the error states we aren't yet sure if they occur in the wild.
https://hg.mozilla.org/mozilla-central/rev/01722571b74b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.