Closed Bug 1139050 Opened 5 years ago Closed 5 years ago

Add moz.build BUG_COMPONENT metadata for xpcom/

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(2 files)

I think everything in xpcom/ just goes in component Core::XPCOM.  Once there's reviewer stuff we'll want to split out the CC stuff into a different set of reviewers.
xpcom/string goes in Core::String.
Assignee: nobody → continuation
Should xpcom/glue/nsStringAPI.h also go in Core::String?
Flags: needinfo?(benjamin)
Yes. Although I don't think edge cases matter that much.
Flags: needinfo?(benjamin)
Good point.

Relatedly, nsAlgorithm.h is in xpcom/string.
I went through and looked at all the subdirectories, and the string stuff was the only thing that looked like it should be in a separate component.  There's a bunch of XPIDL gunk, but that looks like XPCOM.

froydnj is away this week, but there's no big hurry for this.
Attachment #8572164 - Flags: review?(nfroyd)
Comment on attachment 8572164 [details] [diff] [review]
Add moz.build BUG_COMPONENT metadata for xpcom/.

Review of attachment 8572164 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/string/moz.build
@@ +7,5 @@
> +with Files('**'):
> +    BUG_COMPONENT = ('Core', 'String')
> +
> +with Files('nsAlgorithm.h'):
> +    BUG_COMPONENT = ('Core', 'XPCOM')

Want to file a followup bug for moving this file out of xpcom/string/ to, say, xpcom/base/?
Attachment #8572164 - Flags: review?(nfroyd) → review+
Attachment #8575463 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/5fd2f893b4bc
https://hg.mozilla.org/mozilla-central/rev/ba1cb75846f3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.