1139050 - Add moz.build BUG_COMPONENT metadata for xpcom/

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

I think everything in xpcom/ just goes in component Core::XPCOM.  Once there's reviewer stuff we'll want to split out the CC stuff into a different set of reviewers.

Comment 1

[Benjamin Smedberg]

xpcom/string goes in Core::String.

Comment 2

[Andrew McCreight [:mccr8]]

Should xpcom/glue/nsStringAPI.h also go in Core::String?

Comment 3

[Benjamin Smedberg]

Yes. Although I don't think edge cases matter that much.

Comment 4

[Andrew McCreight [:mccr8]]

Good point.

Relatedly, nsAlgorithm.h is in xpcom/string.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Add moz.build BUG_COMPONENT metadata for xpcom/.

I went through and looked at all the subdirectories, and the string stuff was the only thing that looked like it should be in a separate component.  There's a bunch of XPIDL gunk, but that looks like XPCOM.

froydnj is away this week, but there's no big hurry for this.

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8572164 [details] [diff] [review]
Add moz.build BUG_COMPONENT metadata for xpcom/.

Review of attachment 8572164 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/string/moz.build
@@ +7,5 @@
> +with Files('**'):
> +    BUG_COMPONENT = ('Core', 'String')
> +
> +with Files('nsAlgorithm.h'):
> +    BUG_COMPONENT = ('Core', 'XPCOM')

Want to file a followup bug for moving this file out of xpcom/string/ to, say, xpcom/base/?

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Move nsAlgorithm.h to xpcom/base.

Comment 8

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5fd2f893b4bc
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ba1cb75846f3

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5fd2f893b4bc
https://hg.mozilla.org/mozilla-central/rev/ba1cb75846f3