Closed Bug 1139144 Opened 9 years ago Closed 9 years ago

Remove unused empty() definition from databuffer.h

Categories

(Core :: WebRTC: Networking, defect)

Product:
Core
Component:
WebRTC: Networking
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: ekr, Assigned: ekr)

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Remove unused empty() definition from databuffer.h
39 bytes, text/x-review-board-request
mt
: review+
Details 
      No description provided.
Attached file MozReview Request: bz://1139144/ekr (obsolete) — 
/r/4575 - Remove unused empty() definition from databuffer.h

Pull down this commit:

hg pull review -r e4ac1c32fc43008e28464b8f3a7d4f6c3fc31c44
Attachment #8572179 - Flags: review?(martin.thomson)
Comment on attachment 8572179 [details]
MozReview Request: bz://1139144/ekr

/r/4575 - Remove unused empty() definition from databuffer.h

Pull down this commit:

hg pull review -r e4ac1c32fc43008e28464b8f3a7d4f6c3fc31c44
Comment on attachment 8572179 [details]
MozReview Request: bz://1139144/ekr

/r/4575 - Remove unused empty() definition from databuffer.h

Pull down this commit:

hg pull review -r e4ac1c32fc43008e28464b8f3a7d4f6c3fc31c44
Attachment #8572179 - Flags: review?(martin.thomson) → review?(martin.thomson)
Comment on attachment 8572179 [details]
MozReview Request: bz://1139144/ekr

So just hitting the "Ship It!" button in reviewboard doesn't update the flag here.
Attachment #8572179 - Flags: review?(martin.thomson) → review+
Whiteboard: checkin-needed
Keywords: checkin-needed
Whiteboard: checkin-needed
Ryan, seems like something happened on the last merge. Nothing got marked as fixed from https://hg.mozilla.org/mozilla-central/rev/f72ee1bf5567 to https://hg.mozilla.org/mozilla-central/rev/1e4b76918021
Flags: needinfo?(ryanvm)
Flags: needinfo?(ryanvm)
https://hg.mozilla.org/mozilla-central/rev/eeafc0479592
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39

        Attachment #8572179 -
        Attachment is obsolete: true

        Attachment #8619653 -
        Flags: review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: