1139156 - Remove influxdb url from the runner configs [ENV] settings

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Morgan Phillips [:mrrrgn]]

This runs buildbot with the url set in its environment.

Comment 1

[Morgan Phillips [:mrrrgn]]

Attachment: influxurl.runner.diff

This solves the issue by moving the creds into a file.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8572196 [details] [diff] [review]
influxurl.runner.diff

Review of attachment 8572196 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for doing this!

::: modules/runner/files/influxdb_hook.py
@@ +74,5 @@
> +        if os.path.exists(cred_file):
> +            url, name = open(cred_file, 'r').read().strip().split('|')
> +        else:
> +            name = os.environ.get('INFLUXDB_NAME') or sys.argv[2]
> +            url = os.environ.get('INFLUXDB_URL') or sys.argv[3]

Are you going to keep support for the env vars, or is this just for transition purposes?