1139185 - [RTL][Contacts] Email address is not aligned to the right

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: screenshot of issue

Description:
When viewing a contact, their email address is NOT aligned to the right.

Prerequisite:
In RTL language (Arabic)

STR:
1) Create a contact with an email address
2) Tap to view the contact created at step 1

Expected: Email address is right aligned

Actual: Email address is left aligned. See screenshot.

Device: Flame 3.0
BuildID: 20150303010233
Gaia: c8ed1085a67490a1ecd7f275e5de9487e1b93b1d
Gecko: 0b3c520002ad
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

This issue does NOT occur on Flame 2.2. Email address is aligned to the right on 2.2.

Device: Flame 2.2
BuildID: 20150303002527
Gaia: 3d188c414e30acc392253d5389a42352fcfbc183
Gecko: c89aad487aa5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression from 2.2 so nominating this 3.0?

Let's get a regression window.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20150228121824
Gaia: 78fa297b1a35dc58f21a6c9b88f8804d1fb88d35
Gecko: e9bce62caed6
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20150301134024
Gaia: 78c56628848a3bc71886328035da1aa3557df24e
Gecko: 494ab2e30956
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Last Working Gaia & First Broken Gecko - issue does NOT repro
Gaia: 78fa297b1a35dc58f21a6c9b88f8804d1fb88d35
Gecko: 494ab2e30956

Last Working Gecko & First Broken Gaia - issue DOES repro
Gaia: 78c56628848a3bc71886328035da1aa3557df24e
Gecko: e9bce62caed6

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/78fa297b1a35dc58f21a6c9b88f8804d1fb88d35...78c56628848a3bc71886328035da1aa3557df24e


Caused by the patch to Bug 1126587. Note that this bug will be 2.2 affected once that patch gets uplifted to 2.2.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Augustin, can you take a look at this please? Looks like the landing for Bug 1126587 might have caused this to occur.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] autra:bug-1139185 > mozilla-b2g:master

Comment 6

[Augustin Trancart [:autra]]

Comment on attachment 8572539 [details] [review]
[gaia] autra:bug-1139185 > mozilla-b2g:master

Hi Francisco,

Since you were the reviewer of bug 1126587, could you review this follow-up? Basically, I made a mistake when forcing email field to be ltr: we still want it to be right-aligned in RTL language. So I use the same trick than for contact-list. Thanks!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8572539 [details] [review]
[gaia] autra:bug-1139185 > mozilla-b2g:master

Thanks Augusting, tried on the phone and looking find.

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/2f5b24c44920ad89e2372ce3e9ffd1a52128c7df

Comment 9

[Augustin Trancart [:autra]]

Comment on attachment 8572539 [details] [review]
[gaia] autra:bug-1139185 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): #1126587
[User impact] if declined: bad alignment of email in RTL contact detail view
[Testing completed]: on flame 2.2
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: None

Comment 10

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Fixed screenshot

This issue is verified fixed on latest b2g-inbound build. Email address is aligned to the left. See screenshot for fixed behavior.

Device: Flame 3.0
BuildID: 20150306134530
Gaia: 4c6cecb14e5cc20b2e217d5783e8dde4a5145d66
Gecko: afd91b997c2e
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Adding verifyme tag for 2.2 verification after uplift.

Comment 11

[Pi Wei Cheng [:piwei] (inactive)]

Correction on comment 10 observed behavior: email address is aligned to the *RIGHT*.

Comment 12

[KTucker [:KTucker][Inactive 3/4/2016]]

In regards to Comment 9 this is unaffected on 2.2 so I don't know if we need an uplift here.

Comment 13

[KTucker [:KTucker][Inactive 3/4/2016]]

NVM this will be affected once the patch for bug 1126587 gets uplifted to 2.2. Sorry about that.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/27050846d2a766f297130aa2293306a2288204fc

Comment 15

[Shine(Leave from Mozilla)]

Attachment: screenshot

This problem is verified pass on latest build of Flame 2.2.
See attachment: Flame2.2_screenshot1.png
Rate:0/5

Flame 2.2 build: (Pass)
Build ID               20150316162504
Gaia Revision          d0e09d5e6367e558824f9cbf691da99cedf63037
Gaia Date              2015-03-16 17:14:22
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/793d61bb0bd4
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150316.195035
Firmware Date          Mon Mar 16 19:50:48 EDT 2015
Bootloader             L1TC000118D0