113924 - Double FileNotFound property in appstrings.properties

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Marek Wawoczny]

Double FileNotFound property in appstrings.properties, should be only one (?).
http://lxr.mozilla.org/mozilla/source/docshell/base/appstrings.properties#21
http://lxr.mozilla.org/mozilla/source/docshell/base/appstrings.properties#28

Mozilla/5.0 (Windows; U; Windows NT 5.0; pl-PL; rv:0.9.6+) Gecko/20011206

Comment 1

[Asa Dotzler [:asa]]

reassign

Comment 2

[Adam Lock]

Attachment: Removed first version

Rick do you want to r / sr this?

I zapped the first version of fileNotFound because I found the wording more
terse. Please say if you would prefer to see the second one go instead.

Comment 3

[Conrad Carlen (not reading bugmail)]

fileNotFound=%s does not exist or could not be accessed

Can we actually fail because of a permission error? If not, it gives the user
two things to worry about when really all that matters is the file doesn't exist.

Comment 4

[Adam Lock]

The message in question is displayed by nsWebShell when it receives an
NS_ERROR_FILE_NOT_FOUND error result. The network code typically returns this
error if nsILocalFile::Exists returns PR_FALSE. It is possible that incorrect
access rights or a non-existant file could trigger this result depending on the
nsLocalFile impl, so for correctness the error message should cover both cases.

Is the concept of access going to confuse Mac & Win32 users? I could understand
if it said permissions, but access seems fairly straightforward to understand.
If it might cause confusion it can be removed.

Thoughts?

Comment 5

[Adam Lock]

*** Bug 119285 has been marked as a duplicate of this bug. ***

Comment 6

[Adam Lock]

I think deleting the duplicate string would fine for now. If someone has a
problem with the wording, they can always raise a new bug on it. For the record,
webshell has no clue why the error was thrown so it seems sensible that it
suggests the two most likely reasons for the problem.

Comment 7

[Adam Lock]

Looking for an r/sr here. 

Comment 8

[Conrad Carlen (not reading bugmail)]

Comment on attachment 61584 [details] [diff] [review]
Removed first version

Removing the shorter string is fine with me. r=ccarlen

Comment 9

[Adam Lock]

Darin removed the first fileNotFound during a checkin for bug 47617