1139248 - Investigate use of android:windowActionBar on values-v21/styles

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We use it in v11 but don't use it in v21.

Taking so I don't forget about it but someone else can take it if they want to.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sebastian, do you know what this attribute does?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

> Flag indicating whether this window should have an Action Bar in place of the usual title bar. 

http://developer.android.com/reference/android/R.styleable.html#Theme_windowActionBar

Not sure why we would ever want to explicitly disable the ActionBar though.

We only set it to false in GeckoBase and GeckoDialogBase. GeckoDialogBase is not overriden in v21 so we should inherit this style in v21+. It's parent (Theme.Holo.Light.Dialog) already sets windowActionBar to false so it should not be needed. Setting it to false in GeckoBase seems odd assuming the default should be showing an ActionBar. But we don't have many activities and GeckoPreferencesBase sets it to true again. Mhhh. v21 in general is very basic so far. I just recently added the action bar styling but I guess a lot of styles still fallback to Holo in v11+.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Realistically not getting to this.

This should fix itself once we unify our UI across device configurations (bug 1202076).

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.