Closed Bug 1139272 Opened 6 years ago Closed 6 years ago

put expensive nsStyleContext destructor assertions behind a pref

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

The expensive assertions in the nsStyleContext destructor that verifies that destroyed style structs aren't still referenced in the tree somewhere are currently |#if 0| due to how long they can take on large pages.  We have added some crashtests for bugs in the bug 931668 optimizations that are caught be these assertions.  So that we can check that we don't re-introduce problems that cause those crashtests to fail, let's put the assertions behind a pref (though still DEBUG-only) that we can selectively enable for those tests in the crashtest manifest.
Attached file patch
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8572441 - Flags: review?(dbaron)
Attachment #8572441 - Flags: review?(dbaron) → review+
Blocks: 1139723
https://hg.mozilla.org/mozilla-central/rev/f2b0eb82d21d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.