put expensive nsStyleContext destructor assertions behind a pref

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

Trunk
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The expensive assertions in the nsStyleContext destructor that verifies that destroyed style structs aren't still referenced in the tree somewhere are currently |#if 0| due to how long they can take on large pages.  We have added some crashtests for bugs in the bug 931668 optimizations that are caught be these assertions.  So that we can check that we don't re-introduce problems that cause those crashtests to fail, let's put the assertions behind a pref (though still DEBUG-only) that we can selectively enable for those tests in the crashtest manifest.
(Assignee)

Comment 1

4 years ago
Created attachment 8572441 [details]
patch
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8572441 - Flags: review?(dbaron)
(Assignee)

Updated

4 years ago
Blocks: 1139723
https://hg.mozilla.org/mozilla-central/rev/f2b0eb82d21d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.