Improve the job-details pane date format

VERIFIED FIXED

Status

Tree Management
Treeherder
P3
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: darktrojan, Assigned: jfrench)

Tracking

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Dates in treeherder (e.g. lower-left panel) are displayed in m/d/yy format.
Today is shown as 3/4/15, which would make it my birthday, but I have not received presents. :(

Please let me change to the superior d/m/yy format so that I don't have to use silly American dates.
(Assignee)

Comment 1

3 years ago
I'll have a look at this one, and see what I can do.
(Assignee)

Comment 2

3 years ago
Created attachment 8572709 [details]
jobDetailDateFormat_proposed

Hi Geoff, we'd actually like to update it to the same format as the resultset header in the main panel (attached). There is even less ambiguity and it's also localized. Sound ok?
Attachment #8572709 - Flags: feedback?(geoff)
(Assignee)

Comment 3

3 years ago
Created attachment 8572744 [details] [review]
treeherder-ui-PR#400

Please see above PR for review and status. We will hold off merging, pending Geoff's agreement on format.
Attachment #8572744 - Flags: review?(emorley)
(Assignee)

Updated

3 years ago
Summary: Localise dates → Improve the job-details pane date format
(Reporter)

Comment 4

3 years ago
Comment on attachment 8572709 [details]
jobDetailDateFormat_proposed

Format looks good to me. While we're dealing with dates though, I should point out that there's more dates in the annotations and similar jobs panels, that also need fixing.
Attachment #8572709 - Flags: feedback?(geoff) → feedback+
(Assignee)

Comment 5

3 years ago
Cool, I'll have a look at those and try to add them in.

Updated

3 years ago
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED

Comment 6

3 years ago
Comment on attachment 8572744 [details] [review]
treeherder-ui-PR#400

Left a comment :-)
Attachment #8572744 - Flags: review?(emorley) → feedback+
(Assignee)

Updated

3 years ago
Priority: -- → P3

Updated

3 years ago
Attachment #8572744 - Flags: review+

Comment 7

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/77174efef2d83d048cc4bcfd2acfa00670530bd7
Bug 1139301 - Make the date-format consistent and centralized

https://github.com/mozilla/treeherder-ui/commit/995fb932ed9c69ec1273b03220b3d765347793e6
Merge pull request #400 from tojonmz/status-date-adjust

Bug 1139301 - Make the date-format consistent and centralized
(Assignee)

Comment 8

3 years ago
Marking fixed per above merge. I will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

3 years ago
Created attachment 8574803 [details] [review]
treeherder-ui-PR#413-perf_supplemental

Supplemental update for perfherder.
Attachment #8574803 - Flags: review?(wlachance)
Comment on attachment 8574803 [details] [review]
treeherder-ui-PR#413-perf_supplemental

This looks like a good improvement. You'd want to look at dates for datapoints in perfherder for similar reasons as the rest of treeherder (to try and figure out when stuff landed), so sticking to a common scheme makes sense.
Attachment #8574803 - Flags: review?(wlachance) → review+

Comment 11

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/d09d85d5e9eaafd74e72bcb4f21d7c3f69de36f7
Bug 1139301 - Update perfherder date format

https://github.com/mozilla/treeherder-ui/commit/d0b81affd04eb4dc400024eb6e8a51bbeca871a9
Merge pull request #413 from tojonmz/perf-date-format

Bug 1139301 - Update perfherder date format
(Assignee)

Comment 12

3 years ago
I will watch/verify both changes on the next push to stage/prod.
(Assignee)

Comment 13

3 years ago
Verified fixed on stage.
Status: RESOLVED → VERIFIED

Comment 14

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c263a179086d135b8035807a6f0873ae54e5aede
Bug 1139301 - Make the date-format consistent and centralized

https://github.com/mozilla/treeherder/commit/74e2663294e3016474b7951542ba620e3ecc8d42
Merge pull request #400 from tojonmz/status-date-adjust

Bug 1139301 - Make the date-format consistent and centralized

https://github.com/mozilla/treeherder/commit/455e2792518d887aadbf8ee826145f650db78836
Bug 1139301 - Update perfherder date format

https://github.com/mozilla/treeherder/commit/d9b1c1837bb4b278ca836617bde82b82a57a5e9f
Merge pull request #413 from tojonmz/perf-date-format

Bug 1139301 - Update perfherder date format
You need to log in before you can comment on or make changes to this bug.