Closed Bug 1139336 Opened 9 years ago Closed 9 years ago

[Settings] Implement EventEmitter

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:+)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g +

People

(Reporter: arthurcc, Assigned: arthurcc)

Details

Attachments

(1 file)

[gaia] crh0716:1139336 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
eragonj
: review+
eragonj
: feedback+
Details | Review 
Many modules require the ability of emitting events. To reduce the duplicate code we need an EventEmitter that can augment other objects easily.
Comment on attachment 8572551 [details] [review]
[gaia] crh0716:1139336 > mozilla-b2g:master

EJ, could you help provide feedback on this patch? Thanks.
Attachment #8572551 - Flags: feedback?(ejchen)
Comment on attachment 8572551 [details] [review]
[gaia] crh0716:1139336 > mozilla-b2g:master

Thanks Arthur, I just checked it and left some comments on GitHub, please take a look when you have time. Basically they look good to me !
Attachment #8572551 - Flags: feedback?(ejchen) → feedback+
blocking-b2g: backlog → ---
Comment on attachment 8572551 [details] [review]
[gaia] crh0716:1139336 > mozilla-b2g:master

I modified the patch to make EventEmitter extending from Module. EJ, could you help review it? Thanks.
Attachment #8572551 - Flags: review?(ejchen)
Comment on attachment 8572551 [details] [review]
[gaia] crh0716:1139336 > mozilla-b2g:master

It looks great and I left some comments on GitHub, please take a look :)

Thanks Arthur.
Attachment #8572551 - Flags: review?(ejchen)
Comment on attachment 8572551 [details] [review]
[gaia] crh0716:1139336 > mozilla-b2g:master

All comments have been addressed. EJ, would you mind take a look at it again? Thanks.
Attachment #8572551 - Flags: review?(ejchen)
Comment on attachment 8572551 [details] [review]
[gaia] crh0716:1139336 > mozilla-b2g:master

Fantastic ! r+ :)
Attachment #8572551 - Flags: review?(ejchen) → review+
Thanks, EJ!

master: dd96084d0461a9388ac793599b1918ecd43f3fcf
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: