1139338 - [Settings] Refactor Observable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

There are potential memory and performance issues in Observable due to the current way of extending an observable enforces duplicate functions. 

Observable should provide ways making the users be able to derive new type of objects using prototype. To derive robust modules from Observable, there are a few features to be implemented:
- Read-only properties
- Dependency properties where the value of them are derived from other properties.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] crh0716:1139338 > mozilla-b2g:master

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8572556 [details] [review]
[gaia] crh0716:1139338 > mozilla-b2g:master

EJ, the new Observable is backward compatible, but in long term I would like to switch to the new definition. The way it is implemented is based on our offline discussion before. Could you help review it? Thanks.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8572556 [details] [review]
[gaia] crh0716:1139338 > mozilla-b2g:master

Change to feedback? as I found that there are issues when deriving from a module that is derived from a Observable.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8572556 [details] [review]
[gaia] crh0716:1139338 > mozilla-b2g:master

Thanks Arthur, there are still some missing concepts that need to be discussed with you face to face later.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8572556 [details] [review]
[gaia] crh0716:1139338 > mozilla-b2g:master

I've added the tests and docs. Please help review the patch, thanks!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8572556 [details] [review]
[gaia] crh0716:1139338 > mozilla-b2g:master

Thanks Arthur, I just left some comments on GitHub, can you check it when you have time ? Thanks !!! :)

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8572556 [details] [review]
[gaia] crh0716:1139338 > mozilla-b2g:master

EJ, I've addressed the comments. Would you mind take a look at it? Thanks.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8572556 [details] [review]
[gaia] crh0716:1139338 > mozilla-b2g:master

r+ with few comments addressed. Thanks Arthur.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ!

master: dd4bea14aa6ef50be8228141d7728acd60d2d0fc