1139343 - Change existing setBoolPrefs to pushPrefEnv

Status: RESOLVED WONTFIX

(Core :: General, defect)

Description

[Anish]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20140715214327

Steps to reproduce:

https://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=SpecialPowers.setBoolPref%20path%3Alayout%2F
https://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=SpecialPowers.setBoolPref%20path%3Adom/mobilemessage%2F
https://dxr.mozilla.org/mozilla-central/search?limit=100&redirect=false&q=SpecialPowers.setBoolPref%20path%3Adom/tests%2F

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks Anish for filing this.  These above mentioned queries will get about half of the remaining api's converted.

Comment 2

[John Kang]

Hello, I would like to take on this bug if it hasn't been fixed yet.

Comment 3

[Martijn Wargers (dead)]

John, that would be great! Let me know if you need help, I'm available on irc/email/etc.

Comment 4

[John Kang]

Attachment: bug1139343.diff (for test_selectioncarets.py)

Here is the first fix. Please let me know if it was done correctly/needs more.

Comment 5

[Martijn Wargers (dead)]

(In reply to John Kang from comment #4)
> Created attachment 8585105 [details] [diff] [review]
> bug1139343.diff (for test_selectioncarets.py)
> 
> Here is the first fix. Please let me know if it was done correctly/needs
> more.

This is perfect, thanks.

Comment 6

[John Kang]

Attachment: bug1139343.diff

Here's the patch!

Comment 7

[Martijn Wargers (dead)]

Comment on attachment 8585246 [details] [diff] [review]
bug1139343.diff

Review of attachment 8585246 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this part looks good. Try server results here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dcafbc653ac

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I removed the SpecialPower usage for the selection-carets marionette tests in bug 1163490. We do need to land the patch in this bug.