Last Comment Bug 1139345 - Check of last tasks update time faulty
: Check of last tasks update time faulty
Product: Calendar
Classification: Client Software
Component: Provider: GData (show other bugs)
: unspecified
: All All
-- normal (vote)
: 4.1
Assigned To: Geoff Lankow (:darktrojan)
Depends on:
Blocks: 1139228
  Show dependency treegraph
Reported: 2015-03-04 03:23 PST by Geoff Lankow (:darktrojan)
Modified: 2015-03-04 15:16 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

short.diff (1.56 KB, patch)
2015-03-04 03:23 PST, Geoff Lankow (:darktrojan)
philipp: review+
Details | Diff | Splinter Review

Description User image Geoff Lankow (:darktrojan) 2015-03-04 03:23:29 PST
Created attachment 8572561 [details] [diff] [review]

The code tries to subtract 604800 from a 16-bit value.
Comment 1 User image Philipp Kewisch [:Fallen] 2015-03-04 08:37:18 PST
Comment on attachment 8572561 [details] [diff] [review]

Review of attachment 8572561 [details] [diff] [review]:

ugh...we might be having this problem in other parts of the code too, I've always assumed I could subtract any value, and I'm sure we have a few more places where larger values are subtracted. r=philipp for this code, do you think you could check our other code that make changes to seconds?
Comment 2 User image Geoff Lankow (:darktrojan) 2015-03-04 15:16:43 PST
I've just had a look at everything matching /\.second\b/, and I didn't see any more, so hopefully this is the only one. Landing it now.

Note You need to log in before you can comment on or make changes to this bug.