The default bug view has changed. See this FAQ.

Check of last tasks update time faulty

RESOLVED FIXED in 4.1

Status

Calendar
Provider: GData
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8572561 [details] [diff] [review]
short.diff

The code tries to subtract 604800 from a 16-bit value.
Attachment #8572561 - Flags: review?(philipp)
(Assignee)

Updated

2 years ago
Blocks: 1139228
Comment on attachment 8572561 [details] [diff] [review]
short.diff

Review of attachment 8572561 [details] [diff] [review]:
-----------------------------------------------------------------

ugh...we might be having this problem in other parts of the code too, I've always assumed I could subtract any value, and I'm sure we have a few more places where larger values are subtracted. r=philipp for this code, do you think you could check our other code that make changes to seconds?
Attachment #8572561 - Flags: review?(philipp) → review+
(Assignee)

Comment 2

2 years ago
I've just had a look at everything matching /\.second\b/, and I didn't see any more, so hopefully this is the only one. Landing it now.

https://hg.mozilla.org/comm-central/rev/af52234eeaff
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.1
You need to log in before you can comment on or make changes to this bug.