Closed Bug 1139361 Opened 5 years ago Closed 5 years ago

Remove gTLSThreadID*

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

gTLSThreadID and friend were added in bug 580096, but stopped being used after bug 1033358. Interestingly, this is also the only use of NS_TLS, which we might as well remove at the same time (and by the way, I just figured TLS doesn't work on mac (the configure test fails with a "thread-local storage is unsupported for the current target" message in config.log)).
Attached patch Remove gTLSThreadID* and NS_TLS (obsolete) — Splinter Review
Assignee: nobody → mh+mozilla
Attachment #8572577 - Flags: review?(nfroyd)
Comment on attachment 8572577 [details] [diff] [review]
Remove gTLSThreadID* and NS_TLS

Review of attachment 8572577 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/threads/nsThreadManager.cpp
@@ -22,5 @@
> -#ifdef XP_WIN
> -#include <windows.h>
> -DWORD gTLSThreadIDIndex = TlsAlloc();
> -#elif defined(NS_TLS)
> -NS_TLS mozilla::threads::ID gTLSThreadID = mozilla::threads::Generic;

Assuming I don't fail at search:

http://mxr.mozilla.org/mozilla-central/search?find=%2F&string=mozilla%3A%3Athreads

I think this is the last instance of mozilla::threads::ID.  Want to remove it here or in a followup bug?
Attachment #8572577 - Flags: review?(nfroyd) → review+
Attachment #8574975 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/25b744e53faa
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.