Remove gTLSThreadID*

RESOLVED FIXED in Firefox 39

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
gTLSThreadID and friend were added in bug 580096, but stopped being used after bug 1033358. Interestingly, this is also the only use of NS_TLS, which we might as well remove at the same time (and by the way, I just figured TLS doesn't work on mac (the configure test fails with a "thread-local storage is unsupported for the current target" message in config.log)).
(Assignee)

Comment 1

3 years ago
Created attachment 8572577 [details] [diff] [review]
Remove gTLSThreadID* and NS_TLS
Assignee: nobody → mh+mozilla
Attachment #8572577 - Flags: review?(nfroyd)
Comment on attachment 8572577 [details] [diff] [review]
Remove gTLSThreadID* and NS_TLS

Review of attachment 8572577 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/threads/nsThreadManager.cpp
@@ -22,5 @@
> -#ifdef XP_WIN
> -#include <windows.h>
> -DWORD gTLSThreadIDIndex = TlsAlloc();
> -#elif defined(NS_TLS)
> -NS_TLS mozilla::threads::ID gTLSThreadID = mozilla::threads::Generic;

Assuming I don't fail at search:

http://mxr.mozilla.org/mozilla-central/search?find=%2F&string=mozilla%3A%3Athreads

I think this is the last instance of mozilla::threads::ID.  Want to remove it here or in a followup bug?
Attachment #8572577 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8574975 [details] [diff] [review]
Remove gTLSThreadID*, NS_TLS and mozilla::threads::ID

dxr agrees:
https://dxr.mozilla.org/mozilla-central/search?q=%2Btype-ref%3Amozilla%3A%3Athreads%3A%3AID
Attachment #8572577 - Attachment is obsolete: true
Attachment #8574975 - Flags: review?(nfroyd)
Attachment #8574975 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/25b744e53faa
https://hg.mozilla.org/mozilla-central/rev/25b744e53faa
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.