Closed
Bug 1139406
Opened 9 years ago
Closed 9 years ago
Make test_keyboard_predictive_key.py pass on b2g desktop
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
()
Details
Attachments
(1 file)
This test is xfail for b2g desktop, because this line is failing: http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/keyboard/test_keyboard_predictive_key.py#19 http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/keyboard/manifest.ini#14 I think we should make this test run for b2g desktop and let that part fail in the test, so we at least get the complete coverage of the test.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Attachment #8573348 -
Flags: review?(npark)
Attachment #8573348 -
Flags: review?(jlorenzo)
|
||
Updated•9 years ago
|
Attachment #8573348 -
Flags: review?(npark) → review+
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8573348 [details] [review] [gaia] mwargers:test_keyboard_predictive_key.py > mozilla-b2g:master Try is green. It looks good to me!
Attachment #8573348 -
Flags: review?(jlorenzo) → review+
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b328f6545ffbfaec046975c5411c85d611211474
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•