Closed Bug 1139413 Opened 9 years ago Closed 7 years ago

shouldn't need to specify objdir more than once in mozharness configs

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: bhearsum, Unassigned)

Details

In a bunch of mozharness build configs we specify objdir multiple times. Eg in https://github.com/mozilla/build-mozharness/blob/master/configs/builds/releng_base_windows_32_builds.py:
    'objdir': 'obj-firefox',
        'MOZ_OBJDIR': 'obj-firefox',


This is confusing and seems unnecessary. I ended up with builds failing in weird ways when I only changed one and not the other.

I've seen it "fixed" in some by factoring them out to a global var, but that doesn't really seem like a real solution, just a bandaid. We should set it once, and let mozharness copy it to wherever else it needs to be probably.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.