Closed Bug 1139427 Opened 5 years ago Closed 5 years ago

Define file-based metadata in /browser/components

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: aryx, Assigned: aryx)

Details

Attachments

(1 file)

Attached patch patch, v1Splinter Review
moz.build files shall define in which Bugzilla component bugs for a given file should be reported.

Support landed in bug 1132771

Docs: https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/build/buildsystem/files-metadata.html
Attachment #8572629 - Flags: review?(ally)
Comment on attachment 8572629 [details] [diff] [review]
patch, v1

Review of attachment 8572629 [details] [diff] [review]:
-----------------------------------------------------------------

While this looks fine, afaik I don't have review privs for this. Did someone tell you to send this my way?
Attachment #8572629 - Flags: review?(ally)
Comment on attachment 8572629 [details] [diff] [review]
patch, v1

(In reply to Allison Naaktgeboren please NEEDINFO? :ally from comment #1)
> While this looks fine, afaik I don't have review privs for this. Did someone
> tell you to send this my way?
No, I had picked you as reviewer because you were looking for review requests on firefox-dev late last year.
Attachment #8572629 - Flags: review?(gavin.sharp)
Comment on attachment 8572629 [details] [diff] [review]
patch, v1

Thanks for getting this started for browser/!

>diff --git a/browser/components/preferences/moz.build b/browser/components/preferences/moz.build

>+with Files('**'):
>+    BUG_COMPONENT = ('Firefox', 'Preferences')

I think we should only specify this line here. The additional more specific stuff below it is too specific, I think, and not always correct.

>diff --git a/browser/components/selfsupport/moz.build b/browser/components/selfsupport/moz.build

>+with Files('**'):
>+    BUG_COMPONENT = ('Firefox Health Report', 'Client: Desktop')

I don't think this is right. I would omit this directory for now, I'm not sure there is a good component for it specifically.

r=me with those changes.
Attachment #8572629 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/139cb04d9984
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.