Closed Bug 1139437 Opened 9 years ago Closed 9 years ago

[Calendar] simplify the way elements are built on week and day views

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mmedeiros, Assigned: mmedeiros)

Details

Attachments

(1 file)

[gaia] millermedeiros:1139437-simplify-multi-day-view > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review 
we ended up using `document.createElement` for most of the elements inside the new week/day views; which was OK until we had to improve a11y and added many `setAttribute` calls - which increased the complexity of the views and made it harder to understand the markup structure. I think we should move back to external templates and basic `innerHTML` where it would simplify things.

this will make it easier to update the markup in the future.
Assignee: nobody → mmedeiros
Status: NEW → ASSIGNED
Attachment #8577343 - Flags: review?(gaye)
Comment on attachment 8577343 [details] [review]
[gaia] millermedeiros:1139437-simplify-multi-day-view > mozilla-b2g:master

LGTM!
Attachment #8577343 - Flags: review?(gaye) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: