Closed
Bug 1139443
Opened 11 years ago
Closed 8 years ago
[Calendar] simplify utils/overlap
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mmedeiros, Assigned: mmedeiros)
Details
Attachments
(1 file)
right now we need 3 classes to handle overlaps and logic is way more complex than it needs to be since now we re-render all the events of the day when the data changes.
I think we should simplify the "utils/overlap.js" (converting it into a single function) and kill the "conflict_span.js" and "interval_tree.js".
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mmedeiros
Status: NEW → ASSIGNED
Comment 1•11 years ago
|
||
| Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8572908 [details] [review]
[gaia] millermedeiros:1139443-simplify-overlap > mozilla-b2g:master
ended up keeping almost the same API as before but simplified the implementation drastically just by removing the IntervalTree dependency and the "absorb", "remove" and "split" logic (since that isn't needed anymore).
Attachment #8572908 -
Flags: review?(gaye)
Comment 3•8 years ago
|
||
Firefox OS is not being worked on
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•