1139548 - Unified Telemetry doesn't create a saved-session ping for sessions less than 1 minute

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

If you launch Firefox & shut it down immediately, a saved-session ping should be saved in the saved pings directory.
This is no longer the case with the unified Telemetry.

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1139548.patch

This allows shutdown to take place correctly.

Calling |DeferredTask.disarm| before |DeferredTask.finalize| made the latter do nothing, basically ignoring all the async shutdown barriers.

Comment 2

[Vladan Djeric (:vladan)]

Comment on attachment 8573262 [details] [diff] [review]
bug1139548.patch

Review of attachment 8573262 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryPing.jsm
@@ -786,5 @@
>        return cleanup();
>      }
>  
>      // This handles 2) and 3).
> -    this._delayedInitTask.disarm();

do you need to make the same change in TelemetrySession.jsm?

Comment 3

[Alessio Placitelli [:Dexter]]

Good catch. For the "saved-session" fix that is not strictly needed, as |TelemetrySession.shutdownChromeProcess| is a blocker for the TelemetryPing shutdown, so pings were getting saved just by removing the first one.

Still, the |.disarm| in TelemetrySession shutdown doesn't do anything good, so I'm removing it.

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: bug1139548.patch - v2

Removes the call to |_delayedInitTask.disarm| from |TelemetrySession.shutdownChromeProcess|

Comment 5

[Alessio Placitelli [:Dexter]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=039256d7866a

Comment 6

[Alessio Placitelli [:Dexter]]

All green, except for JP oranges that do not seem related.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/a9e7d74b9f5b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a9e7d74b9f5b