Closed Bug 1139548 Opened 6 years ago Closed 6 years ago

Unified Telemetry doesn't create a saved-session ping for sessions less than 1 minute

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: vladan, Assigned: Dexter)

References

Details

Attachments

(1 file, 1 obsolete file)

If you launch Firefox & shut it down immediately, a saved-session ping should be saved in the saved pings directory.
This is no longer the case with the unified Telemetry.
Attached patch bug1139548.patch (obsolete) — Splinter Review
This allows shutdown to take place correctly.

Calling |DeferredTask.disarm| before |DeferredTask.finalize| made the latter do nothing, basically ignoring all the async shutdown barriers.
Attachment #8573262 - Flags: review?(vdjeric)
Comment on attachment 8573262 [details] [diff] [review]
bug1139548.patch

Review of attachment 8573262 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryPing.jsm
@@ -786,5 @@
>        return cleanup();
>      }
>  
>      // This handles 2) and 3).
> -    this._delayedInitTask.disarm();

do you need to make the same change in TelemetrySession.jsm?
Attachment #8573262 - Flags: review?(vdjeric) → review+
Flags: needinfo?(alessio.placitelli)
Good catch. For the "saved-session" fix that is not strictly needed, as |TelemetrySession.shutdownChromeProcess| is a blocker for the TelemetryPing shutdown, so pings were getting saved just by removing the first one.

Still, the |.disarm| in TelemetrySession shutdown doesn't do anything good, so I'm removing it.
Flags: needinfo?(alessio.placitelli)
Removes the call to |_delayedInitTask.disarm| from |TelemetrySession.shutdownChromeProcess|
Attachment #8573262 - Attachment is obsolete: true
Attachment #8573389 - Flags: review+
All green, except for JP oranges that do not seem related.
Keywords: checkin-needed
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/a9e7d74b9f5b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.