1139565 - Add a bit more polish to the help build/job tables

Status: VERIFIED FIXED

(Tree Management :: Treeherder, enhancement, P4)

Description

[Jonathan French (:jfrench)]

I thought it might improve the Help to have a more graphical representation of the build/job table codes, rather than plain letters as they presently are.

Specifically it will allow users to make a more direct association with what they are reading in Help, with what they see in the platform.

There's been positive feedback in channel so I will make the change now. I will include a screen grab here, of the difference.

Comment 1

[Jonathan French (:jfrench)]

Attachment: jobCodesProposed

Attached, showing the enhancement to the job codes. I may go a bit lighter with the icons so they don't overwhelm the columns, but that's the general style.

Comment 2

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#402

Please see above PR for status and review.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8572822 [details] [review]
treeherder-ui-PR#402

This looks great! Feel free to merge.

Comment 4

[Jonathan French (:jfrench)]

Thanks wlach! Will do.

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/ced5b042ba28d5477f00d7aa54e082101247cf0c
Bug 1139565 - Add more polish to the Help build/job tables

https://github.com/mozilla/treeherder-ui/commit/2744a1b7acaad4296dff5088789dd9a7154c36d2
Merge pull request #402 from tojonmz/help-improve-jobcodes

Bug 1139565 - Add more polish to the Help build/job tables

Comment 6

[Jonathan French (:jfrench)]

Marking fixed per above merge. I will verify on the next push to stage/prod.

Comment 7

[Jonathan French (:jfrench)]

Verified fixed on stage.

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ea34e7ed967da3baefb73ebee0d45d91852646ba
Bug 1139565 - Add more polish to the Help build/job tables

https://github.com/mozilla/treeherder/commit/d72ffd7be807a0a2f3074fe68cc18d0781a7425c
Merge pull request #402 from tojonmz/help-improve-jobcodes

Bug 1139565 - Add more polish to the Help build/job tables