Closed Bug 113959 Opened 23 years ago Closed 23 years ago

canceling a cached page load blows away the cache entry

Categories

(Core :: Networking: HTTP, defect, P2)

Product:
Core
Component:
Networking: HTTP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: darin.moz, Assigned: darin.moz)

Details

Attachments

(1 file, 1 obsolete file)

v1.1 patch
811 bytes, patch
gagan
: review+
mscott
: superreview+
Details | Diff | Splinter Review 
nsHttpChannel blows away cache entries whenever a page load doesn't succeed. 
this means that, if a user loads a page from the cache and then stops the page
load part way through, the page will be deleted from the cache.  there's no need
to do this, and moreover it specifically discourages callers from canceling page
loads when the server response is a 304 when that would otherwise be a useful
thing to do.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.9
looks like this isn't a problem when the cache entry is opened only for reading,
such as when we are offline.  however, it is a problem for normal cached loads
as well as 304 redirects.  submitting a simple patch which should do the trick.
Attached patch v1.0 patch (obsolete) — — Splinter Review 
this may work... but it'll need to be tested carefully.  i suspect it may cause
problems for pages that set cache control headers via <meta> html tags.
upping priority
Priority: P3 → P2
Comment on attachment 60757 [details] [diff] [review]
v1.0 patch

this patch causes FinalizeCacheEntry to sometimes not run.  ugh!
Attachment #60757 - Flags: needs-work+
Attached patch v1.1 patch — — Splinter Review 
this patch solves the problem more directly
Attachment #60757 - Attachment is obsolete: true
Comment on attachment 67891 [details] [diff] [review]
v1.1 patch

r=gagan
Attachment #67891 - Flags: review+
Keywords: patch
Comment on attachment 67891 [details] [diff] [review]
v1.1 patch

sr=mscott
Attachment #67891 - Flags: superreview+
fixed-on-trunk
fixed-on-trunk (really!)
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: