1139636 - Add BUG_COMPONENT info for ImageLib

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

We need BUG_COMPONENT info for ImageLib. As far as I can tell this is a two-liner, since everything under image/ belongs in Core :: ImageLib.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Add BUG_COMPONENT info for ImageLib

Here's the patch.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8572882 [details] [diff] [review]
Add BUG_COMPONENT info for ImageLib

Review of attachment 8572882 [details] [diff] [review]:
-----------------------------------------------------------------

You don't need build peer review for Files. But I'll give it here.

::: image/moz.build
@@ +6,5 @@
>  
>  DIRS += ['public', 'src', 'decoders', 'encoders']
>  DIRS += ['build']
>  
> +with Files('**'):

Nit: * is the same as ** unless there is content after the *

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review! I kept the code the same because I honestly don't 100% understand the comment - in UNIX shells there is a difference, after all. I'd expect '**' to match everything recursively under 'image/' and '*' to match everything directly inside 'image/'. Because I don't fully understand what's going on, I feel safest cargo culting the existing code, which was cribbed directly from layout's moz.build.

I will be happy to push a followup to change it if you care enough to explain in more detail. =)

Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb48c14bbed

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2cb48c14bbed