Closed Bug 1139636 Opened 5 years ago Closed 5 years ago

Add BUG_COMPONENT info for ImageLib

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: seth, Assigned: seth)

Details

Attachments

(1 file)

We need BUG_COMPONENT info for ImageLib. As far as I can tell this is a two-liner, since everything under image/ belongs in Core :: ImageLib.
Here's the patch.
Attachment #8572882 - Flags: review?(gps)
Comment on attachment 8572882 [details] [diff] [review]
Add BUG_COMPONENT info for ImageLib

Review of attachment 8572882 [details] [diff] [review]:
-----------------------------------------------------------------

You don't need build peer review for Files. But I'll give it here.

::: image/moz.build
@@ +6,5 @@
>  
>  DIRS += ['public', 'src', 'decoders', 'encoders']
>  DIRS += ['build']
>  
> +with Files('**'):

Nit: * is the same as ** unless there is content after the *
Attachment #8572882 - Flags: review?(gps) → review+
Thanks for the review! I kept the code the same because I honestly don't 100% understand the comment - in UNIX shells there is a difference, after all. I'd expect '**' to match everything recursively under 'image/' and '*' to match everything directly inside 'image/'. Because I don't fully understand what's going on, I feel safest cargo culting the existing code, which was cribbed directly from layout's moz.build.

I will be happy to push a followup to change it if you care enough to explain in more detail. =)

Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb48c14bbed
https://hg.mozilla.org/mozilla-central/rev/2cb48c14bbed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.