1139665 - FetchDriver should check content load policy before proceeding

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: fix

Comment 1

[Andrea Marchesini [:baku]]

Comment on attachment 8572910 [details] [diff] [review]
fix

Review of attachment 8572910 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know enough to say yes/no for this LOAD_BACKGROUND thing.

::: dom/fetch/FetchDriver.cpp
@@ +368,5 @@
>                       nsILoadInfo::SEC_NORMAL,
>                       mRequest->ContentPolicyType(),
>                       mLoadGroup,
>                       nullptr, /* aCallbacks */
> +                     nsIRequest::LOAD_BACKGROUND | credentialsFlag,

Why this?

::: dom/fetch/FetchDriver.h
@@ +13,5 @@
>  #include "nsIStreamListener.h"
>  #include "nsRefPtr.h"
>  
>  #include "mozilla/DebugOnly.h"
>  #include "mozilla/net/ReferrerPolicy.h"

should we remove this header?

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

I removed the LOAD_BACKGROUND change. The header is required since we use DebugOnly<bool>.

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25ded6c22f64

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/25ded6c22f64