Closed Bug 1139665 Opened 6 years ago Closed 6 years ago

FetchDriver should check content load policy before proceeding

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: nsm, Assigned: nsm)

References

Details

Attachments

(1 file)

Attached patch fixSplinter Review
No description provided.
Attachment #8572910 - Attachment is patch: true
Attachment #8572910 - Flags: review?(amarchesini)
Comment on attachment 8572910 [details] [diff] [review]
fix

Review of attachment 8572910 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know enough to say yes/no for this LOAD_BACKGROUND thing.

::: dom/fetch/FetchDriver.cpp
@@ +368,5 @@
>                       nsILoadInfo::SEC_NORMAL,
>                       mRequest->ContentPolicyType(),
>                       mLoadGroup,
>                       nullptr, /* aCallbacks */
> +                     nsIRequest::LOAD_BACKGROUND | credentialsFlag,

Why this?

::: dom/fetch/FetchDriver.h
@@ +13,5 @@
>  #include "nsIStreamListener.h"
>  #include "nsRefPtr.h"
>  
>  #include "mozilla/DebugOnly.h"
>  #include "mozilla/net/ReferrerPolicy.h"

should we remove this header?
Attachment #8572910 - Flags: review?(amarchesini) → review+
I removed the LOAD_BACKGROUND change. The header is required since we use DebugOnly<bool>.
https://hg.mozilla.org/mozilla-central/rev/25ded6c22f64
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.