Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Make use of BUG_COMPONENT metadata

RESOLVED FIXED in 4.1

Status

Calendar
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
x86
Mac OS X

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/build/buildsystem/files-metadata.html
(Assignee)

Comment 1

2 years ago
Created attachment 8572925 [details] [diff] [review]
Fix - v1
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8572925 - Flags: review?(Pidgeot18)
(Assignee)

Comment 2

2 years ago
See bug 1139341 for why we need the empty moz.build

Comment 3

2 years ago
Comment on attachment 8572925 [details] [diff] [review]
Fix - v1

>+++ b/calendar/lightning/moz.build
>@@ -31,3 +31,17 @@
>     'content/lightning.js',
> ]
> 
>+with Files('**'):
>+    BUG_COMPONENT = ('Calendar', 'Lightning Only')
>+
>+with Files('content/suite-*'):
>+    BUG_COMPONENT = ('Calendar', 'Lightning: SeaMonkey Integration')
>+
>+with Files('content/suite-*'):
>+    BUG_COMPONENT = ('Calendar', 'Lightning: SeaMonkey Integration')
>+
Not sure if my eyes are playing tricks, but this appears to be a duplication.
(Assignee)

Comment 4

2 years ago
Created attachment 8574831 [details] [diff] [review]
Fix - v2

Oh thanks for spotting that, not sure where that came from.
Attachment #8572925 - Attachment is obsolete: true
Attachment #8572925 - Flags: review?(Pidgeot18)
Attachment #8574831 - Flags: review?(Pidgeot18)
Comment on attachment 8574831 [details] [diff] [review]
Fix - v2

Review of attachment 8574831 [details] [diff] [review]:
-----------------------------------------------------------------

I only vaguely looked over the lists of bug component metadata, since I'm not familiar with the Calendar side of things.

::: calendar/moz.build
@@ +23,5 @@
> +with Files('**/*.mk'):
> +    BUG_COMPONENT = ('Calendar', 'Build Config')
> +    FINAL = True
> +
> +with Files('**/*.manifest'):

I'm not too sure about this one being true...

::: moz.build
@@ +2,5 @@
> +# This Source Code Form is subject to the terms of the Mozilla Public
> +# License, v. 2.0. If a copy of the MPL was not distributed with this
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +# This file needs to stay here even if empty so that mach will work

You should mention that it's needed specifically for commands like mach file-info.
Attachment #8574831 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 6

2 years ago
Created attachment 8578609 [details] [diff] [review]
Fix - v3

(In reply to Joshua Cranmer [:jcranmer] from comment #5)
> Comment on attachment 8574831 [details] [diff] [review]
> Fix - v2
> 
> Review of attachment 8574831 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I only vaguely looked over the lists of bug component metadata, since I'm
> not familiar with the Calendar side of things.
> 
> ::: calendar/moz.build
> @@ +23,5 @@
> > +with Files('**/*.mk'):
> > +    BUG_COMPONENT = ('Calendar', 'Build Config')
> > +    FINAL = True
> > +
> > +with Files('**/*.manifest'):
> 
> I'm not too sure about this one being true...
Given bug 1143163 I should probably change it to *manifest. It would cover these files:
http://mxr.mozilla.org/comm-central/find?string=manifest%24&tree=comm-central&hint=calendar

I guess they could be seen as belonging to the respective component, I don't think it makes a big difference though. Leaving as build config for now.


> 
> ::: moz.build
> @@ +2,5 @@
> > +# This Source Code Form is subject to the terms of the Mozilla Public
> > +# License, v. 2.0. If a copy of the MPL was not distributed with this
> > +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> > +
> > +# This file needs to stay here even if empty so that mach will work
> 
> You should mention that it's needed specifically for commands like mach
> file-info.
Thanks, I've changed the comment.
Attachment #8574831 - Attachment is obsolete: true
Attachment #8578609 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 7

2 years ago
Pushed to comm-central changeset b924dcfdae95
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.1

Updated

2 years ago
Blocks: 1175735
You need to log in before you can comment on or make changes to this bug.