Closed Bug 1139722 Opened 5 years ago Closed 5 years ago
Create a nested job object with mozprocess instead of insisting on breaking away from a parent job on windows 8
MozReview Request: Bug 1139722 - Allow use of nested job objects in mozprocess on windows versions that support them.
39 bytes, text/x-review-board-request
Tests that need to restart the browser from within the browser will benefit from this functionality, so that after such a restart is performed, mozprocess can still manage (and ultimately kill) the browser when it needs to. The full motivation and investigation of this is in bug 1137388, https://bugzilla.mozilla.org/show_bug.cgi?id=1137388#c18 has the detailed description of the issue on windows. According to https://msdn.microsoft.com/en-us/library/windows/desktop/hh448388%28v=vs.85%29.aspx (verified with some local testing) we can create a nested job object starting with windows 8 instead of requiring breakaway to create a job, as determined by this check: http://hg.mozilla.org/mozilla-central/file/56492f7244a9/testing/mozbase/mozprocess/mozprocess/winprocess.py#l417 This came up because testing on try determined windows 8 slaves run test processes in a job object that doesn't allow breakaway.
Assignee: nobody → cmanchester
OS: Linux → All
Hardware: x86_64 → All
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9e84c09bc54 Waiting on re-triggers for that orange, but they all look like known intermittents.
/r/4787 - Bug 1139722 - Allow use of nested job objects in mozprocess on windows versions that support them. Pull down this commit: hg pull review -r 10b0ea68d2043be31f831f793e5fc25308ceaa26
Comment on attachment 8573386 [details] MozReview Request: bz://1139722/chmanchester /r/4787 - Bug 1139722 - Allow use of nested job objects in mozprocess on windows versions that support them. Pull down this commit: hg pull review -r 10b0ea68d2043be31f831f793e5fc25308ceaa26
Attachment #8573386 - Flags: review?(ahalberstadt)
We can talk about this more if clarification is required. I squinted at the documentation long enough to convince myself this is correct, but my experience with the windows stuff starts with this week, so it's possible I've missed something.
Comment on attachment 8573386 [details] MozReview Request: bz://1139722/chmanchester https://reviewboard.mozilla.org/r/4785/#review3889 Seems reasonable. Congratulations, you understand windows mozprocess more than anyone now!
Attachment #8573386 - Flags: review?(ahalberstadt) → review+
https://reviewboard.mozilla.org/r/4785/#review3901 Thanks for the review. Hooray?
Chris, this sounds great! Will you follow up with a new release of mozprocess once this landed on mozilla-central?
We want to backport bug 1137388 for Firefox 38. So we also have to get this bug backported.
We missed to backport this patch to Firefox 38 while landing the other backports. So it causes test failures. Ryan is going to get this landed on Aurora.
You need to log in before you can comment on or make changes to this bug.