1139780 - Only app update xpcshell tests that need debugging should have debug output

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

The tests have been spamming the log files with debug messages for a long time and only the tests that intermittently fail should add the debug messages to the logs.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Stephen, this replaces a bunch of logTestInfo messages with debugDump messages and adds DEBUG_AUS_TEST = true to the tests that have intermittent bugs open. A skim through of the changes should be all that is needed and I'll push this to try as well for assurance.

Comment 2

[Robert Strong (they/them - no direct email)]

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4facc88b1aa

Comment 3

[Stephen A Pohl [:spohl]]

Comment on attachment 8573107 [details] [diff] [review]
patch

Review of attachment 8573107 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/tests/unit_timermanager/consumerNotifications.js
@@ +472,5 @@
> + *         An optional Components.stack.caller. If not specified
> + *         Components.stack.caller will be used.
> + */
> +function logTestInfo(aText, aCaller) {
> +  let caller = (aCaller ? aCaller : Components.stack.caller);

nit: drop parentheses

@@ +498,5 @@
> + *         Components.stack.caller will be used.
> + */
> +function debugDump(aText, aCaller) {
> +  if (DEBUG_TEST) {
> +    let caller = aCaller ? aCaller : Components.stack.caller;

Let's drop this line and pass aCaller to logTestInfo() directly.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch - comments addressed

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/6f6455b2f8b5

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6f6455b2f8b5