1139817 - TypeError: imgs is undefined in TypeError: imgs is undefined

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Kent James (:rkent)]

Regularly I get this error in the error console:

Timestamp: 3/5/2015 1:59:59 AM
Error: TypeError: imgs is undefined
Source File: chrome://communicator/content/TypeError: imgs is undefined
Line: 63

Comment 1

[Kent James (:rkent)]

Attachment: contentAreaClick.patch

Also check for missing images.

Comment 2

[Jim Porter (:squib)]

Comment on attachment 8573158 [details] [diff] [review]
contentAreaClick.patch

Review of attachment 8573158 [details] [diff] [review]:
-----------------------------------------------------------------

r- but only because the existing code is really ugly, and we should take this opportunity to clean it up a bit.

::: mail/base/content/contentAreaClick.js
@@ +58,5 @@
>    {
>      // Scale any overflowing images, exclude http content.
>      let browser = getBrowser();
>      let doc = browser && browser.contentDocument ? browser.contentDocument : null;
> +    let imgs = doc && !doc.URL.startsWith("http") && doc.images ? doc.images : [];

I'd like this a lot better if it were something like the following. Note that I eliminated the null-check for getBrowser(), because if that returns null, something is seriously wrong, and I think we should log that error. Arguably, the same could be said for contentDocument too.

let doc = getBrowser().contentDocument;
if (!doc || doc.URL.startsWith("http") || !doc.images)
  return;
for (let img of doc.images) {
  // ...
}

Comment 3

[Kent James (:rkent)]

Attachment: rewrite and de-indent

If we're going to change it, let's also remove its indent.

Comment 4

[Kent James (:rkent)]

https://hg.mozilla.org/comm-central/rev/33a9d905aa6e

Comment 5

[Kent James (:rkent)]

Comment on attachment 8573534 [details] [diff] [review]
rewrite and de-indent

https://hg.mozilla.org/releases/comm-aurora/rev/52eeb2c1202f