1139818 - Merge imgRequest public and private sections

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

imgRequest currently has public and private members mixed together, like this:

> class imgRequest {
> private:
>  ...
> public:
>  ...
> private:
>  ...
> public:
>  ...
> private:
>  ...
> };

That makes the code harder to read and maintain.

In this bug I'll merge things together so there is one explicit private section and one public section. Typedefs will go at the beginning of the class definition in the initial, implicitly-private section, just as we generally do in layout code.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Merge imgRequest public and private sections

Here's the patch.

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8573159 [details] [diff] [review]
Merge imgRequest public and private sections

Review of attachment 8573159 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/src/imgRequest.h
@@ +206,5 @@
>  
>    bool HasConsumers();
>  
>  private:
> +  friend class FinishPreparingForNewPartRunnable;

I would move this to line 51.

@@ +208,5 @@
>  
>  private:
> +  friend class FinishPreparingForNewPartRunnable;
> +
> +  virtual ~imgRequest();

no needs for virtual, this is MOZ_FINAL. right?

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

(In reply to Andrea Marchesini (:baku) from comment #2)
> no needs for virtual, this is MOZ_FINAL. right?

I see what you mean, but our style guide requires this, at least by my reading.

Comment 4

[Seth Fowler [:seth] [:s2h]]

Attachment: Merge imgRequest public and private sections

Updated patch and rebased against the new versions of the patches in bug 1139804.

Comment 5

[Seth Fowler [:seth] [:s2h]]

Attachment: Merge imgRequest public and private sections

Rebase.

Comment 6

[Seth Fowler [:seth] [:s2h]]

Pushed to inbound:

29219668983e	Seth Fowler — Bug 1139818 - Merge imgRequest public and private sections. r=baku

Comment 7

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29219668983e