Closed Bug 1139832 Opened 5 years ago Closed 5 years ago

Restrict compacting GC zealousness to zeal collections

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Right now compacting GC does a couple of things to help show up bugs:
 - in 64 bit debug builds, a compacting GC relocates everything
 - in debug builds relocated arenas are mprotected and not released until the next GC

We should restrict this zealousness to when zeal mode collections.  We already have a build where the shell tests are run in CGC zeal mode, and I think it makes sense if possible to add a browser build too.
Attachment #8573196 - Flags: review?(terrence)
Comment on attachment 8573196 [details] [diff] [review]
bug1139832-restrict-cgc-zeal

Review of attachment 8573196 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, makes sense.
Attachment #8573196 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/66772bfc2a64
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.