Restrict compacting GC zealousness to zeal collections

RESOLVED FIXED in Firefox 39

Status

()

Core
JavaScript: GC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Right now compacting GC does a couple of things to help show up bugs:
 - in 64 bit debug builds, a compacting GC relocates everything
 - in debug builds relocated arenas are mprotected and not released until the next GC

We should restrict this zealousness to when zeal mode collections.  We already have a build where the shell tests are run in CGC zeal mode, and I think it makes sense if possible to add a browser build too.
(Assignee)

Comment 1

3 years ago
Created attachment 8573196 [details] [diff] [review]
bug1139832-restrict-cgc-zeal
Attachment #8573196 - Flags: review?(terrence)
Comment on attachment 8573196 [details] [diff] [review]
bug1139832-restrict-cgc-zeal

Review of attachment 8573196 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, makes sense.
Attachment #8573196 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/66772bfc2a64
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.