Closed Bug 1139972 Opened 5 years ago Closed 5 years ago

IPC Proxy for charAt

Categories

(Core :: Disability Access APIs, defect)

36 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
No description provided.
Attachment #8573327 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8573327 [details] [diff] [review]
v1

>+DocAccessibleChild::RecvCharAt(const uint64_t& aID,
>+                               const int32_t& aOffset,
>+                               uint16_t* aChar)
>+{
>+  HyperTextAccessible* acc = IdToHyperTextAccessible(aID);
>+  *aChar = acc && acc->IsTextRole() ?
>+    static_cast<uint16_t>(acc->CharAt(aOffset)) : 0;

I wonder if it should be allowed to call this on accessible where IsTextRole() returns false,  but seems fine for now.
Attachment #8573327 - Flags: review?(tbsaunde+mozbugs) → review+
Just tried to keep the behavior atk backend has.
https://hg.mozilla.org/mozilla-central/rev/9e9fb89350a7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.