Closed Bug 1140045 Opened 9 years ago Closed 9 years ago

Fix regressions caused by enabling desktop reader view toolbar button

Categories

(Toolkit :: Reader Mode, defect, P2)

Product:
Toolkit
Component:
Reader Mode
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

(Keywords: meta) 

Unfortunately, enabling the reader toolbar button caused regressions related to memory/CPU usage, including some pretty bad intermittent test failures, so I'm going to disable this again until we have these sorted out.

We can use this bug to track the issues we need to fix before we can re-enable this.
https://hg.mozilla.org/mozilla-central/rev/2205ab3f21a6
Assignee: nobody → margaret.leibovic
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
If this is the tracking bug now for Reader, why is it marked 'FIXED' ?
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #3)
> If this is the tracking bug now for Reader, why is it marked 'FIXED' ?

Sorry, this was a confusing use of bugzilla. I'll re-summarize and re-open to track what we need to do to re-enable this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Disable desktop reader view toolbar button again because of regressions → Fix regressions caused by enabling desktop reader view toolbar button
Whiteboard: [leave open]
Keywords: meta
My patch for bug 1140172 should prevent us from running into bug 1139250 again, so let's try re-enabling this:
https://hg.mozilla.org/integration/fx-team/rev/c186a66948fb

I'm curious if the talos regressions will re-appear, and if they do, if they will have the same magnitude.
Depends on: 1141757
Depends on: 1142183
Depends on: 1142374
Priority: -- → P2
Closing this out, as all dependencies are fixed.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
You need to log in before you can comment on or make changes to this bug.