1140045 - Fix regressions caused by enabling desktop reader view toolbar button

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P2)

Description

[:Margaret Leibovic]

Unfortunately, enabling the reader toolbar button caused regressions related to memory/CPU usage, including some pretty bad intermittent test failures, so I'm going to disable this again until we have these sorted out.

We can use this bug to track the issues we need to fix before we can re-enable this.

Comment 1

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/2205ab3f21a6

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2205ab3f21a6

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

If this is the tracking bug now for Reader, why is it marked 'FIXED' ?

Comment 4

[:Margaret Leibovic]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #3)
> If this is the tracking bug now for Reader, why is it marked 'FIXED' ?

Sorry, this was a confusing use of bugzilla. I'll re-summarize and re-open to track what we need to do to re-enable this.

Comment 5

[:Margaret Leibovic]

My patch for bug 1140172 should prevent us from running into bug 1139250 again, so let's try re-enabling this:
https://hg.mozilla.org/integration/fx-team/rev/c186a66948fb

I'm curious if the talos regressions will re-appear, and if they do, if they will have the same magnitude.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c186a66948fb

Comment 7

[:Margaret Leibovic]

Closing this out, as all dependencies are fixed.