taskcluster-client(.py): Client libraries should have support for encrypting environment variables

RESOLVED FIXED

Status

Taskcluster
Client Libraries
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jonasfj, Assigned: rail)

Tracking

(Depends on: 1 bug)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We should add support for encrypting env vars into taskcluster-client, both the
node.js client and the python client.
See bug 1140046, and docs: http://docs.taskcluster.net/docker-worker/

And make sure we implement the most recent iteration.
(probably wait for bug 1140046)
Component: TaskCluster → General
Product: Testing → Taskcluster
Component: General → Client Libraries
(Assignee)

Comment 1

2 years ago
Created attachment 8640011 [details] [review]
Add encryption support for the python version
Attachment #8640011 - Flags: review?(jhford)
Comment on attachment 8640011 [details] [review]
Add encryption support for the python version

Looks great.  As mentioned in the pr comments, the taskcluster client uses camel casing as a conscious choice.  Please make sure that your functions, parameters and locals use camel casing.  There are a couple of name changes that I'd like to see as well.

Thanks for writing tests, it's really great to see.

Having companion decryption functions in the library would be nice to see.  Is it a huge amount of work to add decryption?  I'd like for both consumers and also so that the unit tests can ensure that our encrypted env vars are valid and not just a random number generator.

Please r? me again when you've addressed the comments.
Attachment #8640011 - Flags: review?(jhford)
(Assignee)

Comment 3

2 years ago
Comment on attachment 8640011 [details] [review]
Add encryption support for the python version

Take 2
Attachment #8640011 - Flags: review?(jhford)
(Assignee)

Comment 4

2 years ago
Comment on attachment 8640011 [details] [review]
Add encryption support for the python version

Assuming r+ because it was merged
Attachment #8640011 - Flags: review?(jhford) → review+
Assumption correct!  Released as version 0.0.23
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

2 years ago
Thanks!
Assignee: nobody → rail
You need to log in before you can comment on or make changes to this bug.