1140059 - LSAN-detected leaks in the profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Shu-yu Guo [:shu]]

https://treeherder.mozilla.org/logviewer.html#?job_id=5408307&repo=try

Comment 1

[Markus Stange [:mstange]]

I love manual memory management...

Comment 2

[Markus Stange [:mstange]]

This is about mThreadNameFilters, which gets allocated here: https://hg.mozilla.org/mozilla-central/annotate/56492f7244a9/tools/profiler/TableTicker.h#l90

Comment 3

[Shu-yu Guo [:shu]]

Attachment: Stop leaking mThreadNameFilters in the profiler.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8573597 [details] [diff] [review]
Stop leaking mThreadNameFilters in the profiler.

I think UniquePtr<char> ends up doing delete theChar, and not delete[] or free(). I think what we need here is free(). Can you try using an nsString or nsCString or std::string instead?

Comment 5

[Shu-yu Guo [:shu]]

Attachment: Stop leaking mThreadNameFilters in the profiler.

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8573607 [details] [diff] [review]
Stop leaking mThreadNameFilters in the profiler.

Review of attachment 8573607 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/TableTicker.h
@@ +9,5 @@
>  #include "platform.h"
>  #include "ProfileEntry.h"
>  #include "mozilla/Mutex.h"
> +#include "mozilla/Vector.h"
> +#include "mozilla/UniquePtr.h"

Looks like you don't need this anymore.

Comment 7

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Markus Stange [:mstange] from comment #4)
> I think UniquePtr<char> ends up doing delete theChar, and not delete[] or
> free(). I think what we need here is free(). Can you try using an nsString
> or nsCString or std::string instead?

It's also possible to use UniquePtr with a deleter class that calls free(), if a string class won't work here.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e42a8febca65