bootstrap.py gives incorrect git URL

RESOLVED FIXED in Firefox 55

Status

Firefox Build System
General
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: Benjamin Smedberg, Assigned: luisbg)

Tracking

unspecified
mozilla55
x86
Windows 7

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
<gps> bsmedberg: you should use mozilla/gecko-dev on github
<gps> or https://git.mozilla.org/?p=releases/gecko.git;a=summary

Easy to patch, but I'd like a definitive answer about the correct URL.
Flags: needinfo?(gps)

Updated

3 years ago
Flags: needinfo?(gps)

Comment 1

3 years ago
https://git.mozilla.org/?p=releases/gecko.git;a=summary and https://github.com/mozilla/gecko-dev are produced by the same tool. Aside from a very small window between `git push` invocations, the contents should be identical.

Personally, I prefer 3rd parties take hosting responsibilities away from us. Scaling Git servers is hard. I'm happy to advertise github.com as the default URI.
(Assignee)

Comment 2

a year ago
People running bootstrap.py for the first time and looking for the mozilla-central source code might try the git option listed: "git clone https://git.mozilla.org/integration/gecko-dev.git" which fails to find the repository.

This site [0] lists git.mozilla.org as decommissioned.

A google search will point to github.com/mozilla/gecko-dev, but it might be worth it to update the print out of bootstrap.py. Since starting to experience of playing with gecko code with a failure is not very welcoming.

I am happy to offer the patch, just proposing the fix here first before I do so to make sure it would be accepted.

Thanks for the review and help :)


[0] https://wiki.mozilla.org/DeveloperServices/HistoricalVCS
(In reply to Luis de Bethencourt [:luisbg] from comment #2)
> I am happy to offer the patch, just proposing the fix here first before I do
> so to make sure it would be accepted.

Please do!
(Assignee)

Comment 4

a year ago
Created attachment 8861405 [details] [diff] [review]
1140088.patch

Here is the patch.

I haven't submitted a patch to mozilla-central in a long time, so please let me know if you need anything from me besides attaching the patch here and waiting for review.

Thanks :)
(Assignee)

Updated

a year ago
Attachment #8861405 - Flags: review?(nfroyd)
Comment on attachment 8861405 [details] [diff] [review]
1140088.patch

Review of attachment 8861405 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #8861405 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 7

a year ago
Thanks for the review and push Nathan! :)
No problem!
Assignee: nobody → luis

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9fc5b6124839
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Comment 10

a year ago
Ooops I should've changed the status to Resolved. Now I know for next time.

Thanks Wes :)
(In reply to Luis de Bethencourt [:luisbg] from comment #10)
> Ooops I should've changed the status to Resolved. Now I know for next time.
> 
> Thanks Wes :)

Setting the bug status to RESOLVED only happens when the commits are merged to central; that's why Wes is setting the status, not because of anything you forgot to do. :)

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.