1140092 - Remove old call url reception code from the Loop backend

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #1121071 +++

Split out from bug 1120171 as crosses multiple releases.

Now that we're shipping rooms, we don't need the old call url generation code.

Parts to be removed:

- Anything in MozLoopService/MozLoopAPI no longer used, e.g.
-- noteCallUrlExpiry
-- (possibly other things)

Comment 1

[Mark Banner (:standard8)]

Attachment: WIP Remove handling of guest calls from the Loop backend.

This doesn't quite work yet - one of the xpcshell tests is failing, parking here so that I can take a look at it in a different view and so that it doesn't get lost.

Comment 2

[Mark Banner (:standard8)]

Attachment: Remove handling of guest calls from the Loop backend.

Finally worked out what I'd done wrong on one of the promises. This is now ready for review.

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8573569 [details] [diff] [review]
Remove handling of guest calls from the Loop backend.

Review of attachment 8573569 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! I think it's important to push this to Try first (with xpcshell and mochitest enabled) to see if you caught all the things.

::: browser/components/loop/test/xpcshell/head.js
@@ +28,5 @@
>  var loopServer;
>  
>  // Ensure loop is always enabled for tests
>  Services.prefs.setBoolPref("loop.enabled", true);
> +Services.prefs.setCharPref("loop.debug.loglevel", "All");

Why is it necessary to set this pref now?

Comment 4

[Mark Banner (:standard8)]

(In reply to Mike de Boer [:mikedeboer] from comment #3)
> LGTM! I think it's important to push this to Try first (with xpcshell and
> mochitest enabled) to see if you caught all the things.

Well if not, ./browser/components/loop/run-all-loop-tests.sh is broken ;-) But I'll push anyway just in case.

> @@ +28,5 @@
> >  var loopServer;
> >  
> >  // Ensure loop is always enabled for tests
> >  Services.prefs.setBoolPref("loop.enabled", true);
> > +Services.prefs.setCharPref("loop.debug.loglevel", "All");
> 
> Why is it necessary to set this pref now?

It isn't, I was struggling with debugging and it was something I was using for more debug.

Comment 5

[Mark Banner (:standard8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f48861cd09bd

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/95efe38a63d6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95efe38a63d6