1140106 - [Settings] Arrows are shifted too close to the right edge

Status: RESOLVED DUPLICATE of bug 1141840

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: ArrowsInSettings.png

Description:
In settings, the arrows are moved to closer the right edge. When scroll bar appears, it overlaps with the arrows.

Note: 
This issue does NOT occur when in RTL mode.

Repro Steps:
1) Update a Flame to 20150305010212.
2) Go to Settings, and observe the arrows on the right side of the screen.

Actual:
The arrows are close to the right edge of the screen, and they overlap with the scroll bar.

Expected:
There is enough space between the arrows and the right edge. The arrows do not overlap with the scroll bar.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150305010212
Gaia: eff3321ab4e65da3f906688ebb55ddf1e93d9452
Gecko: 56492f7244a9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 5/5
See attached: screenshot

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does NOT reproduce on Flame 2.2.

Result: There is enough space between the arrows and the right edge. The arrows do not overlap with the scroll bar.

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150305002528
Gaia: 89af288bad6751248ff84504fa898206fee127fe
Gecko: 6d8d294aa8f3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Regression from 2.2 so nominating 3.0? The arrows should not overlap the scroll bar.

Let's get a regression window here.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

2.2 is now affected. Tested with latest tinderbox central build.

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20150304063851
Gaia: 2b84f08d6c0f2a6cba5620c1442fd01b9e7dbfac
Gecko: 7af4ffef0d26
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20150304071452
Gaia: 3f2003f6deb5ee642fd3a0a361e5bfe0f7cf28f6
Gecko: 59eda9046f57
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Last Working Gaia & First Broken Gecko - issue does NOT repro
Gaia: 2b84f08d6c0f2a6cba5620c1442fd01b9e7dbfac
Gecko: 59eda9046f57

Last Working Gecko & First Broken Gaia - issue DOES repro
Gaia: 3f2003f6deb5ee642fd3a0a361e5bfe0f7cf28f6
Gecko: 7af4ffef0d26

https://github.com/mozilla-b2g/gaia/compare/2b84f08d6c0f2a6cba5620c1442fd01b9e7dbfac...3f2003f6deb5ee642fd3a0a361e5bfe0f7cf28f6

Caused by patch for Bug 1118861.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

^ Correction, I tested with latest tinderbox 2.2 build, not central.

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Guillaume, can you take a look at this please? Looks like this might have been caused by landing and uplift for bug 1118861.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1140106-Settings-Arrows-are-shifted-too-close-to-the-right-edge > mozilla-b2g:master

Comment 7

[Guillaume Marty [:gmarty]]

Comment on attachment 8573905 [details] [review]
[gaia] gmarty:Bug-1140106-Settings-Arrows-are-shifted-too-close-to-the-right-edge > mozilla-b2g:master

The patch is very small. Can you r+ Vivien?

Comment 8

[Guillaume Marty [:gmarty]]

Comment on attachment 8573905 [details] [review]
[gaia] gmarty:Bug-1140106-Settings-Arrows-are-shifted-too-close-to-the-right-edge > mozilla-b2g:master

Or Jose if you have time? It's just a CSS one-liner change.

Comment 9

[howie [:howie]]

this bug should be fixed already, ni Arthur to dup this bug.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

The bug has been fixed in bug 1141840. Mark as a duplicate of it.