114013 - static build fails to link libxpinstall.so

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Colin Blake]

I just tried a static build and everything went find except for one problem. In 
the link of libxpinstall.so (xpinstall/src), it couldn't find the mozjs library. 
The reference is MOZ_JS_LIBS which is defined as -L$(DIST)/bin -lmozjs. Problem 
is that when libmozjs.a was built in js/src it got installed to dist/lib, not 
dist/bin.

dist/lib does appear on the libxpinstall ld command line, but its AFTER -lmozjs. 
Doesn't ld only search -L directories that were specified BEFORE the -l ??
That's certainly the way I have it working on OpenVMS.

Comment 1

[hacker formerly known as [e-mail]]

It might depend upon the linker although I would expect the behavior that you
are seeing.  Here's the quick fix:

Index: xpinstall/src/Makefile.in

-               -L$(DIST)/bin \
+               $(LIBS_DIR) \

Comment 2

[Colin Blake]

Yep, that ought to do it.

Comment 3

[Brian Ryner (not reading)]

r=bryner

Comment 4

[Colin Blake]

I verified that this change fixed the problem on OpenVMS.

Comment 5

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 6

[hacker formerly known as [e-mail]]

Checking in xpinstall/src/Makefile.in;
/cvsroot/mozilla/xpinstall/src/Makefile.in,v  <--  Makefile.in
new revision: 1.58; previous revision: 1.57
done

Comment 7

[Tracy Walker [:tracy]]

verified