Closed Bug 1140155 Opened 6 years ago Closed 6 years ago

Add .t style tests for Autoland framework

Categories

(Conduit :: Transplant, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dminor, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

Follow on to bug 1138989, use vct style .t tests for Autoland rather than the current unit tests.
Since we last spoke about this, there is a unittest-based framework in place now. See testing/vcttesting/unittest.py. It even has Selenium support (although that part is new and still somewhat fragile).

If you want to write Python unit tests, go for it. They certainly make more sense for things that aren't CLI based, which most of the content in v-c-t has historically been.
Attached file MozReview Request: bz://1140155/dminor (obsolete) —
/r/4967 - autoland: create .t style tests for autoland (bug 1140155); r=gps

Pull down this commit:

hg pull review -r 20fa60814b566e0cfc2455df067e528a7ca1ca0c
Attachment #8573958 - Flags: review?(gps)
Attachment #8573958 - Flags: review?(gps) → review+
Comment on attachment 8573958 [details]
MozReview Request: bz://1140155/dminor

https://reviewboard.mozilla.org/r/4965/#review3945

I only glanced over the test specifics. The rest of this looks good.

::: hgext/reviewboard/tests/helpers.sh
(Diff revision 1)
> -  mozreview start `pwd` --mercurial-port $HGPORT --reviewboard-port $HGPORT1 --bugzilla-port $HGPORT2 --pulse-port $HGPORT3 > /dev/null
> +  mozreview start `pwd` --mercurial-port $HGPORT --reviewboard-port $HGPORT1 --bugzilla-port $HGPORT2 --pulse-port $HGPORT3 --autoland-port $HGPORT4 > /dev/null

Just so you are aware, the $HGPORT<N> variables are hard-coded in run-tests.py (which comes from upstream Mercurial). 4 is currently the highest number (which we've had to increase from the default of 3 upstream). Adding another port will cause the tests to explode.
Thanks, https://hg.mozilla.org/hgcustom/version-control-tools/rev/3b8a10644a71
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8573958 - Attachment is obsolete: true
Attachment #8619685 - Flags: review+
Product: Tree Management → MozReview
Product: MozReview → Conduit
You need to log in before you can comment on or make changes to this bug.