IPC Proxy for TextAttributes and DefaultTextAttributes

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

36 Branch
mozilla39
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 8573564 [details] [diff] [review]
v1
Attachment #8573564 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8573564 [details] [diff] [review]
v1

>diff --git a/accessible/atk/nsMaiInterfaceText.cpp b/accessible/atk/nsMaiInterfaceText.cpp
>--- a/accessible/atk/nsMaiInterfaceText.cpp
>+++ b/accessible/atk/nsMaiInterfaceText.cpp
>@@ -1,32 +1,90 @@
> /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> /* vim: set ts=2 et sw=2 tw=80: */
> /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this
>  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> 
> #include "InterfaceInitFuncs.h"
>-
>+#include "mozilla/a11y/PDocAccessible.h"

given we end up needing to include this around a bit I'm kind of tempted to start dropping the silly wrappers on ProxyAccessible and just directly call stuff on DocAccessibleParent

>+ConvertToAtkTextAttributeSet(nsTArray<Attribute>& aAttributes)
>+{
>+  AtkAttributeSet* objAttributeSet = nullptr;
>+  for (uint32_t i = 0; i < aAttributes.Length(); ++i) {

technically I think it should be size_t since that's what Length() returns.
Attachment #8573564 - Flags: review?(tbsaunde+mozbugs) → review+
(Assignee)

Comment 2

4 years ago
Created attachment 8574030 [details] [diff] [review]
size_t
(Assignee)

Comment 3

4 years ago
Created attachment 8574078 [details] [diff] [review]
v2 (merge)
Attachment #8574030 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/7fa300ea1b1d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.