1140162 - IPC Proxy for TextAttributes and DefaultTextAttributes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8573564 [details] [diff] [review]
v1

>diff --git a/accessible/atk/nsMaiInterfaceText.cpp b/accessible/atk/nsMaiInterfaceText.cpp
>--- a/accessible/atk/nsMaiInterfaceText.cpp
>+++ b/accessible/atk/nsMaiInterfaceText.cpp
>@@ -1,32 +1,90 @@
> /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> /* vim: set ts=2 et sw=2 tw=80: */
> /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this
>  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> 
> #include "InterfaceInitFuncs.h"
>-
>+#include "mozilla/a11y/PDocAccessible.h"

given we end up needing to include this around a bit I'm kind of tempted to start dropping the silly wrappers on ProxyAccessible and just directly call stuff on DocAccessibleParent

>+ConvertToAtkTextAttributeSet(nsTArray<Attribute>& aAttributes)
>+{
>+  AtkAttributeSet* objAttributeSet = nullptr;
>+  for (uint32_t i = 0; i < aAttributes.Length(); ++i) {

technically I think it should be size_t since that's what Length() returns.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: size_t

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2 (merge)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fa300ea1b1d

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7fa300ea1b1d