Log type of user for all requests

RESOLVED FIXED

Status

Hello (Loop)
Server
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Katie Parlante, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [loop-metrics])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
RT's terminology for user type:

- Registered User: a FxA registered desktop client user
- Unregistered User: a non FxA registered desktop client user
- Link clicker user: a URL link clicker on a WebRTC browser
- Unreachable user: a URL link clicker on a non WebRTC browser

It would be ideal if we could log the type of user (as described above) for every loop server request.
For the last one, how are we supposed to detect it on server side?
Created attachment 8575312 [details] [review]
Link to Github PR — #318.
Attachment #8575312 - Flags: review?(mathieu)
What I can do is to return `Unreachable User` on the GET /rooms/:token when the user is not connected and then as soon as it uses its sessionToken, we can return a link-clicker User

Also a real Unreachable user will be somebody that doesn't have a "join" as a link-clicker on the same room.

Will that work for you or do you prefer us to call everyone Link-Clicker as soon as they are unauthenticated users?
Flags: needinfo?(kparlante)
After thinking more about it, I think it is better to have only three user types:

- REGISTERED: "Registered User",
- UNREGISTERED: "Unregistered User",
- UNAUTHENTICATED: "Link-clicker User"

kparlante — does this works for you?
We should use the user agent to detect that the Link-Clicker uses a non WebRTC browser.
Attachment #8575312 - Flags: review?(mathieu) → review+
(Reporter)

Comment 6

3 years ago
(In reply to Rémy Hubscher (:natim) from comment #4)
> After thinking more about it, I think it is better to have only three user
> types:
> 
> - REGISTERED: "Registered User",
> - UNREGISTERED: "Unregistered User",
> - UNAUTHENTICATED: "Link-clicker User"
> 
> kparlante — does this works for you?

Yes, works for me.

(In reply to Rémy Hubscher (:natim) from comment #5)
> We should use the user agent to detect that the Link-Clicker uses a non
> WebRTC browser.

Agreed, that logic can live in the heka filter. Separate bug.
Flags: needinfo?(kparlante)
That's released. https://github.com/mozilla-services/loop-server/commit/9dbaade3b30d70570165a1a3307c6807013d7055
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.