1140183 - Disable the safe-mode key trigger (shift on win, option on mac) using an environment variable

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Jesse Ruderman]

Attachment: patch

The safe-mode key makes it annoying to run tests on a workstation, especially tests that start many browser instances. This patch follows the precedent of bug 745154 by adding an environment variable to disable the safe mode trigger.

This does not fix bug 507782, bug 539403, or bug 653410.

Comment 1

[Matthew N. [:MattN]]

This could also be useful to address bug 1090478 comment 3.

Comment 2

[(no longer active)]

Comment on attachment 8573591 [details] [diff] [review]
patch

Review of attachment 8573591 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +3305,5 @@
>    }
>  #endif
>  
>  #ifdef XP_MACOSX
> +  if ((GetCurrentEventKeyModifiers() & optionKey) && !EnvHasValue("MOZ_DISABLE_SAFE_MODE_KEY"))

Nit: please break into two lines.

Comment 3

[Jesse Ruderman]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6ea1fa736a3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b6ea1fa736a3

Comment 5

[horvath.agoston]

@Jesse

Just for the poor souls in my track.

To set that env variable on macos, create the file /etc/launchd.conf and enter (or append if exists) this line:

setenv MOZ_DISABLE_SAFE_MODE_KEY 1

save, reboot and you should be good to go.

Comment 6

[sashabe]

@horvath.agoston's tip doesn't work on High Sierra.

Comment 7

[sashabe]

(In reply to sashabe from comment #6)
> @horvath.agoston's tip doesn't work on High Sierra.

However, this recommendation https://stackoverflow.com/a/47252708/102397 has worked for me.